Changeset 120354 in webkit

Timestamp:

Jun 14, 2012 1:08:26 PM (12 years ago)

Author:

eae@chromium.org

Message:

Change RenderTableSection::calcRowLogicalHeight to round rather than floor height
​https://bugs.webkit.org/show_bug.cgi?id=88813

Reviewed by Julien Chaffraix.

Source/WebCore:

Change RenderTableSection::calcRowLogicalHeight to round the
logicalHeight instead of flooring it. This matches our rounding logic
elsewhere and results in table rows better matching the expected height.

Test: fast/sub-pixel/table-rows-have-stable-height.html

• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

LayoutTests:

Add new test ensuring that rows are laid out the desired height when
given a height that maps to a device pixel value.

• fast/sub-pixel/table-rows-have-stable-height-expected.txt: Added.
• fast/sub-pixel/table-rows-have-stable-height.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/sub-pixel/table-rows-have-stable-height-expected.txt (added)
• LayoutTests/fast/sub-pixel/table-rows-have-stable-height.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderTableSection.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-06-14  Emil A Eklund  <eae@chromium.org>
+
+        Change RenderTableSection::calcRowLogicalHeight to round rather than floor height
+        https://bugs.webkit.org/show_bug.cgi?id=88813
+
+        Reviewed by Julien Chaffraix.
+
+        Add new test ensuring that rows are laid out the desired height when
+        given a height that maps to a device pixel value.
+
+        * fast/sub-pixel/table-rows-have-stable-height-expected.txt: Added.
+        * fast/sub-pixel/table-rows-have-stable-height.html: Added.
+
 2012-06-14  Zan Dobersek  <zandobersek@gmail.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-06-14  Emil A Eklund  <eae@chromium.org>
+
+        Change RenderTableSection::calcRowLogicalHeight to round rather than floor height
+        https://bugs.webkit.org/show_bug.cgi?id=88813
+
+        Reviewed by Julien Chaffraix.
+
+        Change RenderTableSection::calcRowLogicalHeight to round the
+        logicalHeight instead of flooring it. This matches our rounding logic
+        elsewhere and results in table rows better matching the expected height.
+
+        Test: fast/sub-pixel/table-rows-have-stable-height.html
+
+        * rendering/RenderTableSection.cpp:
+        (WebCore::RenderTableSection::calcRowLogicalHeight):
+
 2012-06-14  Andrey Adaikin  <aandrey@chromium.org>
 

trunk/Source/WebCore/rendering/RenderTableSection.cpp

@@ -334 +334 @@
 
         // Our base size is the biggest logical height from our cells' styles (excluding row spanning cells).
-        m_rowPos[r + 1] = max(m_rowPos[r] + minimumIntValueForLength(m_grid[r].logicalHeight, 0, viewRenderer), 0);
+        m_rowPos[r + 1] = max(m_rowPos[r] + minimumValueForLength(m_grid[r].logicalHeight, 0, viewRenderer).round(), 0);
 
         Row& row = m_grid[r].row;