Changeset 120736 in webkit

Timestamp:

Jun 19, 2012 11:03:22 AM (12 years ago)

Author:

dpranke@chromium.org

Message:

new-run-webkit-tests reports unexpected pass of pixel tests when pixel testing is disabled
​https://bugs.webkit.org/show_bug.cgi?id=85446

Reviewed by Simon Fraser.

Tools:

Embed whether pixel testing was enabled into the results.json.

• Scripts/webkitpy/layout_tests/controllers/manager.py:

(summarize_results):

LayoutTests:

This change makes results.html aware of whether pixel tests were
enabled when the tests were run; if they weren't, we ignore
expected IMAGE tests that pass instead of reporting them as
'unexpected pass'.

• fast/harness/resources/results-test.js:

(mockResults):

• fast/harness/results.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/harness/resources/results-test.js (modified) (1 diff)
• LayoutTests/fast/harness/results.html (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-06-19  Dirk Pranke  <dpranke@chromium.org>
+
+        new-run-webkit-tests reports unexpected pass of pixel tests when pixel testing is disabled
+        https://bugs.webkit.org/show_bug.cgi?id=85446
+
+        Reviewed by Simon Fraser.
+
+        This change makes results.html aware of whether pixel tests were
+        enabled when the tests were run; if they weren't, we ignore
+        expected IMAGE tests that pass instead of reporting them as
+        'unexpected pass'.
+
+        * fast/harness/resources/results-test.js:
+        (mockResults):
+        * fast/harness/results.html:
+
 2012-06-19  Andreas Kling  <kling@webkit.org>
 

trunk/LayoutTests/fast/harness/resources/results-test.js

@@ -31 +31 @@
         "has_pretty_patch": false,
         "has_wdiff": false,
-        "revision": 12345
+        "revision": 12345,
+        "pixel_tests_enabled": true
     };
 }

trunk/LayoutTests/fast/harness/results.html

@@ -487 +487 @@
 
     if (actual == 'PASS' && expected != 'PASS') {
-        globalState().unexpectedPassTests.push(testObject);
+        if (expected != 'IMAGE' || globalState().results.pixel_tests_enabled) {
+            globalState().unexpectedPassTests.push(testObject);
+        }
         return;
     }

trunk/Tools/ChangeLog

@@ +1 @@
+2012-06-19  Dirk Pranke  <dpranke@chromium.org>
+
+        new-run-webkit-tests reports unexpected pass of pixel tests when pixel testing is disabled
+        https://bugs.webkit.org/show_bug.cgi?id=85446
+
+        Reviewed by Simon Fraser.
+
+        Embed whether pixel testing was enabled into the results.json.
+
+        * Scripts/webkitpy/layout_tests/controllers/manager.py:
+        (summarize_results):
+
 2012-06-19  Zoltan Horvath  <zoltan@webkit.org>
 

trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

@@ -237 +237 @@
     results['has_wdiff'] = port_obj.wdiff_available()
     results['has_pretty_patch'] = port_obj.pretty_patch_available()
+    results['pixel_tests_enabled'] = port_obj.get_option('pixel_tests')
+
     try:
         # We only use the svn revision for using trac links in the results.html file,