Changeset 121646 in webkit

Timestamp:

Jul 1, 2012 5:27:20 PM (12 years ago)

Author:

timothy@apple.com

Message:

Make the "Inspect Element" context menu item appear in nightly builds again.

rdar://problem/11702613
​https://webkit.org/b/89323

Reviewed by Dan Bernstein.

Source/WebCore:

• platform/ContextMenuItem.h:

Fix the order of the ContextMenuAction enum to be binary compatible with
older versions of WebKit.

Source/WebKit/mac:

• WebView/WebUIDelegatePrivate.h:

Add missing enums that were added in ContextMenuItem.h but left out here.

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/ContextMenuItem.h (modified) (2 diffs)
• WebKit/mac/ChangeLog (modified) (1 diff)
• WebKit/mac/WebView/WebUIDelegatePrivate.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-07-01  Timothy Hatcher  <timothy@apple.com>
+
+        Make the "Inspect Element" context menu item appear in nightly builds again.
+
+        rdar://problem/11702613
+        https://webkit.org/b/89323
+
+        Reviewed by Dan Bernstein.
+
+        * platform/ContextMenuItem.h:
+        Fix the order of the ContextMenuAction enum to be binary compatible with
+        older versions of WebKit.
+
 2012-07-01  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/WebCore/platform/ContextMenuItem.h

@@ -135 +135 @@
         ContextMenuItemTagPDFSinglePageScrolling,
         ContextMenuItemTagPDFFacingPagesScrolling,
-        ContextMenuItemTagDictationAlternative,
 #if ENABLE(INSPECTOR)
         ContextMenuItemTagInspectElement,
@@ -165 +164 @@
         ContextMenuItemTagMediaPlayPause,
         ContextMenuItemTagMediaMute,
+        ContextMenuItemTagDictationAlternative,
         ContextMenuItemBaseCustomTag = 5000,
         ContextMenuItemCustomTagNoAction = 5998,

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2012-07-01  Timothy Hatcher  <timothy@apple.com>
+
+        Make the "Inspect Element" context menu item appear in nightly builds again.
+
+        rdar://problem/11702613
+        https://webkit.org/b/89323
+
+        Reviewed by Dan Bernstein.
+
+        * WebView/WebUIDelegatePrivate.h:
+        Add missing enums that were added in ContextMenuItem.h but left out here.
+
 2012-06-29  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebKit/mac/WebView/WebUIDelegatePrivate.h

@@ -90 +90 @@
     WebMenuItemTagCapitalize,
     WebMenuItemTagChangeBack,
+    WebMenuItemTagOpenMediaInNewWindow,
+    WebMenuItemTagCopyMediaLinkToClipboard,
+    WebMenuItemTagToggleMediaControls,
+    WebMenuItemTagToggleMediaLoop,
+    WebMenuItemTagEnterVideoFullscreen,
+    WebMenuItemTagMediaPlayPause,
+    WebMenuItemTagMediaMute,
+    WebMenuItemTagDictationAlternative,
+    WebMenuItemBaseCustomTag = 5000,
+    WebMenuItemCustomTagNoAction = 5998,
+    WebMenuItemLastCustomTag = 5999,
     WebMenuItemTagBaseApplication = 10000
 };