Changeset 121755 in webkit


Ignore:
Timestamp:
Jul 3, 2012 3:25:36 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[CSS Regions] Enabling regions on Windows lead to crash-on-launch for WebKit.exe
https://bugs.webkit.org/show_bug.cgi?id=90435

Patch by Mihai Balan <mibalan@adobe.com> on 2012-07-03
Reviewed by Csaba Osztrogonác.

Initial patch for enabling regions led to WebKit crashing on launch. Moving the
IDL declarations for CSS regions getter/setter at the end of the file solves the
problem. As per http://trac.webkit.org/changeset/95650 seems it has to do with
binary compatibility.

  • Interfaces/IWebPreferences.idl: Mover getter/setter for CSS regions at the end of file
Location:
trunk/Source/WebKit/win
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/win/ChangeLog

    r121707 r121755  
     12012-07-03  Mihai Balan  <mibalan@adobe.com>
     2
     3        [CSS Regions] Enabling regions on Windows lead to crash-on-launch for WebKit.exe
     4        https://bugs.webkit.org/show_bug.cgi?id=90435
     5
     6        Reviewed by Csaba Osztrogonác.
     7
     8        Initial patch for enabling regions led to WebKit crashing on launch. Moving the
     9        IDL declarations for CSS regions getter/setter at the end of the file solves the
     10        problem. As per http://trac.webkit.org/changeset/95650 seems it has to do with
     11        binary compatibility.
     12
     13        * Interfaces/IWebPreferences.idl: Mover getter/setter for CSS regions at the end of file
     14
    1152012-07-02  Benjamin Poulain  <bpoulain@apple.com>
    216
  • trunk/Source/WebKit/win/Interfaces/IWebPreferences.idl

    r121597 r121755  
    125125    HRESULT setPlugInsEnabled([in] BOOL enabled);
    126126
    127     HRESULT isCSSRegionsEnabled([out, retval] BOOL* enabled);
    128     HRESULT setCSSRegionsEnabled([in] BOOL enabled);
    129 
    130127    HRESULT allowsAnimatedImages([out, retval] BOOL* enabled);
    131128    HRESULT setAllowsAnimatedImages([in] BOOL enabled);
     
    211208    HRESULT setShouldDisplayTextDescriptions(BOOL shouldDisplayTextDescriptions);
    212209    HRESULT shouldDisplayTextDescriptions(BOOL *shouldDisplayTextDescriptions);
     210
     211    HRESULT isCSSRegionsEnabled([out, retval] BOOL* enabled);
     212    HRESULT setCSSRegionsEnabled([in] BOOL enabled);
    213213}
Note: See TracChangeset for help on using the changeset viewer.