Changeset 121776 in webkit

Timestamp:

Jul 3, 2012 9:15:24 AM (12 years ago)

Author:

thakis@chromium.org

Message:

-Wunused-private-field cleanup, linux edition
​https://bugs.webkit.org/show_bug.cgi?id=90463

Reviewed by Stephen White.

• DumpRenderTree/chromium/DRTDevToolsAgent.h:
• DumpRenderTree/chromium/GamepadController.h:

(GamepadController):

• DumpRenderTree/chromium/NotificationPresenter.h:

(NotificationPresenter::NotificationPresenter):
(NotificationPresenter):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/chromium/DRTDevToolsAgent.h (modified) (1 diff)
• DumpRenderTree/chromium/GamepadController.cpp (modified) (1 diff)
• DumpRenderTree/chromium/GamepadController.h (modified) (1 diff)
• DumpRenderTree/chromium/NotificationPresenter.h (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-07-03  Nico Weber  <thakis@chromium.org>
+
+        -Wunused-private-field cleanup, linux edition
+        https://bugs.webkit.org/show_bug.cgi?id=90463
+
+        Reviewed by Stephen White.
+
+        * DumpRenderTree/chromium/DRTDevToolsAgent.h:
+        * DumpRenderTree/chromium/GamepadController.h:
+        (GamepadController):
+        * DumpRenderTree/chromium/NotificationPresenter.h:
+        (NotificationPresenter::NotificationPresenter):
+        (NotificationPresenter):
+
 2012-07-03  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Tools/DumpRenderTree/chromium/DRTDevToolsAgent.h

@@ -89 +89 @@
     DRTDevToolsClient* m_drtDevToolsClient;
     int m_routingID;
-    WebKit::WebDevToolsAgent* m_webDevToolsAgent;
     WebKit::WebView* m_webView;
 };

trunk/Tools/DumpRenderTree/chromium/GamepadController.cpp

@@ -36 +36 @@
 using namespace WebKit;
 
-GamepadController::GamepadController(TestShell* shell)
-    : m_shell(shell)
+GamepadController::GamepadController(TestShell*)
 {
     bindMethod("connect", &GamepadController::connect);

trunk/Tools/DumpRenderTree/chromium/GamepadController.h

@@ -60 +60 @@
     void fallbackCallback(const CppArgumentList&, CppVariant*);
 
-    TestShell* m_shell;
-
     WebKit::WebGamepads internalData;
 };

trunk/Tools/DumpRenderTree/chromium/NotificationPresenter.h

@@ -44 +44 @@
 class NotificationPresenter : public WebKit::WebNotificationPresenter {
 public:
-    explicit NotificationPresenter(TestShell* shell) : m_shell(shell) { }
+    explicit NotificationPresenter(TestShell*) { }
     virtual ~NotificationPresenter();
 
@@ -63 +63 @@
 
 private:
-    // Non-owned pointer. The NotificationPresenter is owned by the test shell.
-    TestShell* m_shell;
-
     // Set of allowed origins.
     HashSet<WTF::String> m_allowedOrigins;