Changeset 121897 in webkit

Timestamp:

Jul 5, 2012 3:52:48 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
​https://bugs.webkit.org/show_bug.cgi?id=88608

Patch by Dongwoo Im <​dw.im@samsung.com> on 2012-07-05
Reviewed by Hajime Morita.

.:

• Source/cmake/OptionsEfl.cmake: Enable the CUSTOM_SCHEME_HANDLER feature as default.

Source/WebKit2:

• WebProcess/WebCoreSupport/WebChromeClient.h:

(WebKit::WebChromeClient::isProtocolHandlerRegistered): Add a stub function.
(WebKit::WebChromeClient::unregisterProtocolHandler): Add a stub function.
(WebChromeClient):

Tools:

• Scripts/webkitperl/FeatureList.pm: Enable the CUSTOM_SCHEME_HANDLER feature as default.

LayoutTests:

• platform/efl/fast/dom/unregister-protocol-handler-expected.txt: Expected result of the EFL port.

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/efl/fast/dom/unregister-protocol-handler-expected.txt (added)
• Source/WebKit2/ChangeLog (modified) (1 diff)
• Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h (modified) (1 diff)
• Source/cmake/OptionsEfl.cmake (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/Scripts/webkitperl/FeatureList.pm (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2012-07-05  Dongwoo Im  <dw.im@samsung.com>
+
+        [EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
+        https://bugs.webkit.org/show_bug.cgi?id=88608
+
+        Reviewed by Hajime Morita.
+
+        * Source/cmake/OptionsEfl.cmake: Enable the CUSTOM_SCHEME_HANDLER feature as default.
+
 2012-07-05  Ryuan Choi  <ryuan.choi@samsung.com>
 

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-07-05  Dongwoo Im  <dw.im@samsung.com>
+
+        [EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
+        https://bugs.webkit.org/show_bug.cgi?id=88608
+
+        Reviewed by Hajime Morita.
+
+        * platform/efl/fast/dom/unregister-protocol-handler-expected.txt: Expected result of the EFL port.
+
 2012-07-05  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
 

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2012-07-05  Dongwoo Im  <dw.im@samsung.com>
+
+        [EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
+        https://bugs.webkit.org/show_bug.cgi?id=88608
+
+        Reviewed by Hajime Morita.
+
+        * WebProcess/WebCoreSupport/WebChromeClient.h:
+        (WebKit::WebChromeClient::isProtocolHandlerRegistered): Add a stub function.
+        (WebKit::WebChromeClient::unregisterProtocolHandler): Add a stub function.
+        (WebChromeClient):
+
 2012-07-05  Ryuan Choi  <ryuan.choi@samsung.com>
 

trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h

@@ -221 +221 @@
 #endif
 
+#if ENABLE(CUSTOM_SCHEME_HANDLER)
+    virtual CustomHandlersState isProtocolHandlerRegistered(const String&, const String&, const String&) { return CustomHandlersDeclined; }
+    virtual void unregisterProtocolHandler(const String&, const String&, const String&) { }
+#endif
+
     String m_cachedToolTip;
     mutable RefPtr<WebFrame> m_cachedFrameSetLargestFrame;

trunk/Source/cmake/OptionsEfl.cmake

@@ -72 +72 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_IMAGE_SET ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_VARIABLES ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CUSTOM_SCHEME_HANDLER ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DATALIST ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DRAG_SUPPORT ON)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-07-05  Dongwoo Im  <dw.im@samsung.com>
+
+        [EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
+        https://bugs.webkit.org/show_bug.cgi?id=88608
+
+        Reviewed by Hajime Morita.
+
+        * Scripts/webkitperl/FeatureList.pm: Enable the CUSTOM_SCHEME_HANDLER feature as default.
+
 2012-07-05  Ryuan Choi  <ryuan.choi@samsung.com>
 

trunk/Tools/Scripts/webkitperl/FeatureList.pm

@@ -179 +179 @@
 
     { option => "custom-scheme-handler", desc => "Toggle Custom Scheme Handler support",
-      define => "ENABLE_CUSTOM_SCHEME_HANDLER", default => isBlackBerry(), value => \$customSchemeHandlerSupport },
+      define => "ENABLE_CUSTOM_SCHEME_HANDLER", default => (isBlackBerry() || isEfl()), value => \$customSchemeHandlerSupport },
 
     { option => "datalist", desc => "Toggle Datalist support",