Changeset 121988 in webkit

Timestamp:

Jul 6, 2012 11:36:31 AM (12 years ago)

Author:

zandobersek@gmail.com

Message:

[Gtk] Add a configuration option for disabling unstable features in releases
​https://bugs.webkit.org/show_bug.cgi?id=87995

Reviewed by Martin Robinson.

.:

Add a configuration flag for enabling the unstable features - features of which
support in the Gtk port is being worked on but is not yet complete. The primary
use of this flag is when compiling through the build-webkit script.

All the features that are currently enabled when building through build-webkit but
are disabled by default when executing the configure script directly have their default
value (when the correspondent flag is not passed) set to 'yes' when unstable features
are enabled and 'no' otherwise. This way unstable features are kept disabled when performing
a release build (unless they are specifically enabled).

• configure.ac:

Tools:

Pass the --enable-unstable-features flag when building the Gtk port through build-webkit.

• Scripts/webkitdirs.pm:

(buildAutotoolsProject):

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/Scripts/webkitdirs.pm (modified) (1 diff)
• configure.ac (modified) (9 diffs)

trunk/ChangeLog

@@ +1 @@
+2012-07-06  Zan Dobersek  <zandobersek@gmail.com>
+
+        [Gtk] Add a configuration option for disabling unstable features in releases
+        https://bugs.webkit.org/show_bug.cgi?id=87995
+
+        Reviewed by Martin Robinson.
+
+        Add a configuration flag for enabling the unstable features - features of which
+        support in the Gtk port is being worked on but is not yet complete. The primary
+        use of this flag is when compiling through the build-webkit script.
+
+        All the features that are currently enabled when building through build-webkit but
+        are disabled by default when executing the configure script directly have their default
+        value (when the correspondent flag is not passed) set to 'yes' when unstable features
+        are enabled and 'no' otherwise. This way unstable features are kept disabled when performing
+        a release build (unless they are specifically enabled).
+
+        * configure.ac:
+
 2012-07-06  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
 

trunk/Tools/ChangeLog

@@ +1 @@
+2012-07-06  Zan Dobersek  <zandobersek@gmail.com>
+
+        [Gtk] Add a configuration option for disabling unstable features in releases
+        https://bugs.webkit.org/show_bug.cgi?id=87995
+
+        Reviewed by Martin Robinson.
+
+        Pass the --enable-unstable-features flag when building the Gtk port through build-webkit.
+
+        * Scripts/webkitdirs.pm:
+        (buildAutotoolsProject):
+
 2012-07-06  Jessie Berlin  <jberlin@apple.com>
 

trunk/Tools/Scripts/webkitdirs.pm

@@ -2067 +2067 @@
     }
 
+    # Enable unstable features when building through build-webkit.
+    push @buildArgs, "--enable-unstable-features";
+
     # We might need to update jhbuild dependencies.
     my $needUpdate = 0;

trunk/configure.ac

@@ -528 +528 @@
 AC_MSG_RESULT([$enable_optimizations])
 
+# check whether to enable unstable features
+AC_MSG_CHECKING([whether to enable unstable features])
+AC_ARG_ENABLE(unstable_features,
+              AC_HELP_STRING([--enable-unstable-features],
+                             [enable unstable features [default=no]]),
+              [],[enable_unstable_features="no"])
+AC_MSG_RESULT([$enable_unstable_features])
+
 found_opengl="no"
 if test "$with_target" = "x11"; then
@@ -651 +659 @@
               AC_HELP_STRING([--enable-gamepad],
                              [enable Gamepad support [default=no]]),
-              [],[enable_gamepad="no"])
+              [],[enable_gamepad=$enable_unstable_features])
 AC_MSG_RESULT([$enable_gamepad])
 
@@ -672 +680 @@
               AC_HELP_STRING([--enable-mutation-observers],
                              [enable DOM mutation observer support [default=no]]),
-              [],[enable_mutation_observers="no"])
+              [],[enable_mutation_observers=$enable_unstable_features])
 AC_MSG_RESULT([$enable_mutation_observers])
 
@@ -757 +765 @@
               AC_HELP_STRING([--enable-video-track],
                              [enable HTML5 video track support [default=no]]),
-              [],[enable_video_track="no"])
+              [],[enable_video_track=$enable_unstable_features])
 AC_MSG_RESULT([$enable_video_track])
 
@@ -789 +797 @@
               AC_HELP_STRING([--enable-media-stream],
                              [enable media stream support (incomplete) [default=no]]),
-              [],[enable_media_stream="no"])
+              [],[enable_media_stream=$enable_unstable_features])
 AC_MSG_RESULT([$enable_media_stream])
 
@@ -947 +955 @@
               AC_HELP_STRING([--enable-web-timing],
                              [enable support for Web Timing [default=no]]),
-              [],[enable_web_timing="no"])
+              [],[enable_web_timing=$enable_unstable_features])
 AC_MSG_RESULT([$enable_web_timing])
 
@@ -987 +995 @@
               AC_HELP_STRING([--enable-css3-flexbox],
                              [enable CSS3 flexbox support [default=no]]),
-              [],[enable_css3_flexbox="no"])
+              [],[enable_css3_flexbox=$enable_unstable_features])
 AC_MSG_RESULT([$enable_css3_flexbox])
 
@@ -1044 +1052 @@
 AC_ARG_ENABLE([link-prefetch],
   [AS_HELP_STRING([--enable-link-prefetch], [Enable Link prefetch support (default: disabled)])],
-  [],[enable_link_prefetch=no])
+  [],[enable_link_prefetch=$enable_unstable_features])
 AC_MSG_RESULT([$enable_link_prefetch])
 
@@ -1391 +1399 @@
 # WebKit feature conditionals
 AM_CONDITIONAL([ENABLE_DEBUG],[test "$enable_debug_features" = "yes"])
+AM_CONDITIONAL([ENABLE_UNSTABLE_FEATURES],[test "$enable_unstable_features" = "yes"])
 AM_CONDITIONAL([ENABLE_WEBGL],[test "$enable_webgl" = "yes"])
 AM_CONDITIONAL([ENABLE_BLOB],[test "$enable_blob" = "yes"])