Changeset 122037 in webkit

Timestamp:

Jul 6, 2012 3:44:57 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[Qt] Avoid deep copy of QImage in GraphicsContext3D::getImageData()
​https://bugs.webkit.org/show_bug.cgi?id=90705

Patch by Lauro Neto <​lauro.neto@openbossa.org> on 2012-07-06
Reviewed by Noam Rosenthal.

Use QImage.constBits() as argument to packPixels instead of bits() to avoid
deep copying it.

• platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::getImageData):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/qt/GraphicsContext3DQt.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-07-06  Lauro Neto  <lauro.neto@openbossa.org>
+
+        [Qt] Avoid deep copy of QImage in GraphicsContext3D::getImageData()
+        https://bugs.webkit.org/show_bug.cgi?id=90705
+
+        Reviewed by Noam Rosenthal.
+
+        Use QImage.constBits() as argument to packPixels instead of bits() to avoid
+        deep copying it.
+
+        * platform/graphics/qt/GraphicsContext3DQt.cpp:
+        (WebCore::GraphicsContext3D::getImageData):
+
 2012-07-06  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp

@@ -530 +530 @@
     outputVector.resize(packedSize);
 
-    return packPixels(qtImage.bits(), SourceFormatBGRA8, image->width(), image->height(), 0, format, type, alphaOp, outputVector.data());
+    return packPixels(qtImage.constBits(), SourceFormatBGRA8, image->width(), image->height(), 0, format, type, alphaOp, outputVector.data());
 }