Changeset 122054 in webkit
- Timestamp:
- Jul 7, 2012 12:49:34 PM (12 years ago)
- Location:
- trunk
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r122052 r122054 1 2012-07-07 Zan Dobersek <zandobersek@gmail.com> 2 3 REGRESSION (r122035): fullscreen/exit-full-screen-iframe.html failing on GTK Linux 64-bit Release 4 https://bugs.webkit.org/show_bug.cgi?id=90719 5 6 Reviewed by Martin Robinson. 7 8 Remove the crashing test expectation for the affected test. 9 10 * platform/gtk/TestExpectations: 11 1 12 2012-07-07 Filip Pizlo <fpizlo@apple.com> 2 13 -
trunk/LayoutTests/platform/gtk/TestExpectations
r122048 r122054 373 373 374 374 BUGWK90589 RELEASE : fast/css/user-drag-none.html = CRASH TIMEOUT 375 376 BUGWK90719 : fullscreen/exit-full-screen-iframe.html = CRASH377 375 378 376 ////////////////////////////////////////////////////////////////////////////////////////// -
trunk/Source/WebKit/gtk/ChangeLog
r121707 r122054 1 2012-07-07 Zan Dobersek <zandobersek@gmail.com> 2 3 REGRESSION (r122035): fullscreen/exit-full-screen-iframe.html failing on GTK Linux 64-bit Release 4 https://bugs.webkit.org/show_bug.cgi?id=90719 5 6 Reviewed by Martin Robinson. 7 8 Follow the approach of the BlackBerry port outlined in r122035, using in exitFullScreenForElement 9 the fullscreen element to which the reference was saved when enterFullScreenForElement was called. 10 11 * WebCoreSupport/ChromeClientGtk.cpp: 12 (WebKit::ChromeClient::exitFullScreenForElement): 13 1 14 2012-07-02 Benjamin Poulain <bpoulain@apple.com> 2 15 -
trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp
r120918 r122054 946 946 } 947 947 948 void ChromeClient::exitFullScreenForElement(WebCore::Element* element) 949 { 948 void ChromeClient::exitFullScreenForElement(WebCore::Element*) 949 { 950 // The element passed into this function is not reliable, i.e. it could 951 // be null. In addition the parameter may be disappearing in the future. 952 // So we use the reference to the element we saved above. 953 ASSERT(m_fullScreenElement); 954 950 955 gboolean returnValue; 951 GRefPtr<WebKitDOMHTMLElement> kitElement(adoptGRef(kit(reinterpret_cast<HTMLElement*>( element))));956 GRefPtr<WebKitDOMHTMLElement> kitElement(adoptGRef(kit(reinterpret_cast<HTMLElement*>(m_fullScreenElement.get())))); 952 957 g_signal_emit_by_name(m_webView, "leaving-fullscreen", kitElement.get(), &returnValue); 953 958 if (returnValue) … … 958 963 g_signal_handlers_disconnect_by_func(window, reinterpret_cast<void*>(onFullscreenGtkKeyPressEvent), this); 959 964 960 element->document()->webkitWillExitFullScreenForElement(element);965 m_fullScreenElement->document()->webkitWillExitFullScreenForElement(m_fullScreenElement.get()); 961 966 gtk_window_unfullscreen(GTK_WINDOW(window)); 962 967 m_adjustmentWatcher.enableAllScrollbars(); 963 element->document()->webkitDidExitFullScreenForElement(element);968 m_fullScreenElement->document()->webkitDidExitFullScreenForElement(m_fullScreenElement.get()); 964 969 m_fullScreenElement.clear(); 965 970 }
Note: See TracChangeset
for help on using the changeset viewer.