Changeset 122103 in webkit

Timestamp:

Jul 9, 2012 5:28:12 AM (12 years ago)

Author:

Carlos Garcia Campos

Message:

[SOUP] Use soup_cookie_jar_is_persistent() to set whether cookie is a session one or not
​https://bugs.webkit.org/show_bug.cgi?id=90769

Reviewed by Gustavo Noronha Silva.

It's currently set to false, because there were no API to know
whether cookies were persistent or not. Now that we bumped libsoup
requirements, we can use soup_cookie_jar_is_persistent().

• platform/network/soup/CookieJarSoup.cpp:

(WebCore::getRawCookies):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/soup/CookieJarSoup.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-07-09  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [SOUP] Use soup_cookie_jar_is_persistent() to set whether cookie is a session one or not
+        https://bugs.webkit.org/show_bug.cgi?id=90769
+
+        Reviewed by Gustavo Noronha Silva.
+
+        It's currently set to false, because there were no API to know
+        whether cookies were persistent or not. Now that we bumped libsoup
+        requirements, we can use soup_cookie_jar_is_persistent().
+
+        * platform/network/soup/CookieJarSoup.cpp:
+        (WebCore::getRawCookies):
+
 2012-07-09  Taiju Tsuiki  <tzik@chromium.org>
 

trunk/Source/WebCore/platform/network/soup/CookieJarSoup.cpp

@@ -163 +163 @@
         if (!soup_cookie_applies_to_uri(cookie.get(), uri.get()))
             continue;
-        // FIXME: we are currently passing false always for session because there's no API to know
-        // whether SoupCookieJar is persistent or not. We could probably add soup_cookie_jar_is_persistent().
         rawCookies.append(Cookie(String::fromUTF8(cookie->name), String::fromUTF8(cookie->value), String::fromUTF8(cookie->domain),
                                  String::fromUTF8(cookie->path), static_cast<double>(soup_date_to_time_t(cookie->expires)) * 1000,
-                                 cookie->http_only, cookie->secure, false));
+                                 cookie->http_only, cookie->secure, soup_cookie_jar_is_persistent(jar)));
     }