Changeset 122169 in webkit

Timestamp:

Jul 9, 2012 5:08:36 PM (12 years ago)

Author:

scheib@chromium.org

Message:

Pointer Lock requestPointerLock rejects locking an element not in a document.
​https://bugs.webkit.org/show_bug.cgi?id=90821

Reviewed by Adrienne Walker.

Source/WebCore:

Test: pointer-lock/lock-element-not-in-dom.html

• page/PointerLockController.cpp:

(WebCore::PointerLockController::requestPointerLock):

LayoutTests:

• pointer-lock/lock-element-not-in-dom-expected.txt: Added.
• pointer-lock/lock-element-not-in-dom.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/pointer-lock/lock-element-not-in-dom-expected.txt (added)
• LayoutTests/pointer-lock/lock-element-not-in-dom.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/PointerLockController.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-07-09  Vincent Scheib  <scheib@chromium.org>
+
+        Pointer Lock requestPointerLock rejects locking an element not in a document.
+        https://bugs.webkit.org/show_bug.cgi?id=90821
+
+        Reviewed by Adrienne Walker.
+
+        * pointer-lock/lock-element-not-in-dom-expected.txt: Added.
+        * pointer-lock/lock-element-not-in-dom.html: Added.
+
 2012-07-09  Eric Seidel  <eric@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-07-09  Vincent Scheib  <scheib@chromium.org>
+
+        Pointer Lock requestPointerLock rejects locking an element not in a document.
+        https://bugs.webkit.org/show_bug.cgi?id=90821
+
+        Reviewed by Adrienne Walker.
+
+        Test: pointer-lock/lock-element-not-in-dom.html
+
+        * page/PointerLockController.cpp:
+        (WebCore::PointerLockController::requestPointerLock):
+
 2012-07-09  Eric Seidel  <eric@webkit.org>
 

trunk/Source/WebCore/page/PointerLockController.cpp

@@ -51 +51 @@
     if (!target)
         return;
+
+    if (!target->inDocument()) {
+        enqueueEvent(eventNames().webkitpointerlockerrorEvent, target);
+        return;
+    }
 
     if (isLocked()) {