Context Navigation

Changeset 122338 in webkit

Timestamp:

Jul 11, 2012 9:56:18 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Deleting content at the top of prettypatch emails destroys HTML formatting
https://bugs.webkit.org/show_bug.cgi?id=90700
<rdar://problem/7488232>

Patch by Alice Cheng <alice_cheng@apple.com> on 2012-07-11
Reviewed by David Kilzer.

Location:

trunk/Websites/bugs.webkit.org

Files:

-                      r122276
+                      r122338
+-07-11  Alice Cheng  <alice_cheng@apple.com>
+        Deleting content at the top of prettypatch emails destroys HTML formatting
+        https://bugs.webkit.org/show_bug.cgi?id=90700
+        <rdar://problem/7488232>
+        Reviewed by David Kilzer.
+        * PrettyPatch/PrettyPatch.rb:
 -07-10  Adam Barth  <abarth@webkit.org>

-                      r119010
+                      r122338
         $last_prettify_part_count = { "remove" => 0, "add" => 0, "shared" => 0, "binary" => 0, "extract-error" => 0 }
         string = normalize_line_ending(string)
         str = HEADER + "\n"
+        str = "#{HEADER}<body>\n"
         # Just look at the first line to see if it is an SVN revision number as added
 …
             match = /^Subversion\ Revision: (\d*)$/.match(line)
             unless match.nil?
                 str += "<span class='revision'>" + match[1] + "</span>\n"
+                str << "<span class='revision'>#{match[1]}</span>\n"
                 $svn_revision = match[1].to_i;
             end
 …
         $last_prettify_file_count = fileDiffs.length
+        str += fileDiffs.collect{ |diff| diff.to_html }.join
+        str << fileDiffs.collect{ |diff| diff.to_html }.join
+        str << "</body></html>"
     end
 …
     HEADER =<<EOF
+<html>
+<head>
 <style>
 :link, :visited {
 …
 <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script>
 <script src="code-review.js?version=43"></script>
+</head>
 EOF

Note: See TracChangeset for help on using the changeset viewer.