Changeset 122368 in webkit
- Timestamp:
- Jul 11, 2012 2:03:49 PM (12 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r122363 r122368 1 2012-07-11 Huang Dongsung <luxtella@company100.net> 2 3 BitmapImage::frameIsCompleteAtIndex() must return false if ImageDecoder is not initialized. 4 https://bugs.webkit.org/show_bug.cgi?id=90757 5 6 Reviewed by Simon Fraser. 7 8 The current code fortunately has worked so far because only 9 BitmapImage::startAnimation calls frameIsCompleteAtIndex, and startAnimation 10 cannot call frameIsCompleteAtIndex if ImageDecoder is not yet initialized. 11 startAnimation returns at the first line becase shouldAnimate() always return 12 false in this case. 13 14 if (m_frameTimer || !shouldAnimate() || frameCount() <= 1) 15 return; 16 17 This change is needed because parallel image decoders call 18 BitmapImage::frameIsCompleteAtIndex in other places too. 19 20 No new tests, manually tested whether the caller exists or not that 21 calls BitmapImage::frameIsCompleteAtIndex() before ImageDecoder is 22 initialized. 23 24 * platform/graphics/BitmapImage.cpp: 25 (WebCore::BitmapImage::frameIsCompleteAtIndex): 26 1 27 2012-07-11 Kevin Ollivier <kevino@theolliviers.com> 2 28 -
trunk/Source/WebCore/platform/graphics/BitmapImage.cpp
r122269 r122368 305 305 { 306 306 if (!ensureFrameIsCached(index)) 307 return true; // Why would an invalid index return true here?307 return false; 308 308 return m_frames[index].m_isComplete; 309 309 }
Note: See TracChangeset
for help on using the changeset viewer.