Changeset 122467 in webkit


Ignore:
Timestamp:
Jul 12, 2012 9:01:01 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[GTK] Implement disableImageLoading in DRT
​https://bugs.webkit.org/show_bug.cgi?id=87973

Patch by Arnaud Renevier <​arno@renevier.net> on 2012-07-12
Reviewed by Martin Robinson.

Tools:

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::disableImageLoading):

LayoutTests:

Add TEXT expectation to favicon-loads-with-icon-loading-override.html
which was only working by accident.

  • platform/gtk/TestExpectations:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r122464 r122467  
     12012-07-12  Arnaud Renevier  <arno@renevier.net>
     2
     3        [GTK] Implement disableImageLoading in DRT
     4        https://bugs.webkit.org/show_bug.cgi?id=87973
     5
     6        Reviewed by Martin Robinson.
     7
     8        Add TEXT expectation to favicon-loads-with-icon-loading-override.html
     9        which was only working by accident.
     10
     11        * platform/gtk/TestExpectations:
     12
    1132012-07-12  Adam Barth  <abarth@webkit.org>
    214

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r122448 r122467  
    12111211BUGWK87088 : fast/js/names.html = TEXT
    12121212
    1213 BUGWK87973 : http/tests/misc/favicon-loads-with-images-disabled.html = TEXT
     1213BUGWKGTK   : http/tests/misc/favicon-loads-with-icon-loading-override.html = TEXT
    12141214
    12151215BUGWK84102 : fast/profiler/dead-time.html = TEXT

  • trunk/Tools/ChangeLog

    r122440 r122467  
     12012-07-12  Arnaud Renevier  <arno@renevier.net>
     2
     3        [GTK] Implement disableImageLoading in DRT
     4        https://bugs.webkit.org/show_bug.cgi?id=87973
     5
     6        Reviewed by Martin Robinson.
     7
     8        * DumpRenderTree/gtk/DumpRenderTree.cpp:
     9        (resetDefaultsToConsistentValues):
     10        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
     11        (LayoutTestController::disableImageLoading):
     12
    1132012-07-12  Simon Hausmann  <simon.hausmann@nokia.com>
    214

  • trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp

    r122349 r122467  
    465465                 "enable-page-cache", FALSE,
    466466                 "auto-resize-window", TRUE,
     467                 "auto-load-images", TRUE,
    467468                 "enable-java-applet", FALSE,
    468469                 "enable-plugins", TRUE,

  • trunk/Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp

    r122256 r122467  
    450450void LayoutTestController::disableImageLoading()
    451451{
    452     // FIXME: Implement for testing fix for https://bugs.webkit.org/show_bug.cgi?id=27896
    453     // Also need to make sure image loading is re-enabled for each new test.
     452    WebKitWebView* view = webkit_web_frame_get_web_view(mainFrame);
     453    ASSERT(view);
     454
     455    WebKitWebSettings* settings = webkit_web_view_get_settings(view);
     456    g_object_set(G_OBJECT(settings), "auto-load-images", FALSE, NULL);
    454457}
    455458
Note: See TracChangeset for help on using the changeset viewer.