Changeset 122614 in webkit

Timestamp:

Jul 13, 2012 12:05:21 PM (12 years ago)

Author:

haraken@chromium.org

Message:

[V8] String wrappers should be marked Independent
​https://bugs.webkit.org/show_bug.cgi?id=91251

Reviewed by Adam Barth.

Currently V8 String wrappers are not marked Independent.
By marking them Independent, they can be reclaimed by the scavenger GC.

I tried to find some cases where this change reduces memory usage,
but couldn't due to sensitive behavior of GC.

No tests. No change in behavior.

• bindings/v8/V8Binding.cpp:

(WebCore::StringCache::v8ExternalStringSlow):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/V8Binding.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-07-13  Kentaro Hara  <haraken@chromium.org>
+
+        [V8] String wrappers should be marked Independent
+        https://bugs.webkit.org/show_bug.cgi?id=91251
+
+        Reviewed by Adam Barth.
+
+        Currently V8 String wrappers are not marked Independent.
+        By marking them Independent, they can be reclaimed by the scavenger GC.
+
+        I tried to find some cases where this change reduces memory usage,
+        but couldn't due to sensitive behavior of GC.
+
+        No tests. No change in behavior.
+
+        * bindings/v8/V8Binding.cpp:
+        (WebCore::StringCache::v8ExternalStringSlow):
+
 2012-07-13  Peter Beverloo  <peter@chromium.org>
 

trunk/Source/WebCore/bindings/v8/V8Binding.cpp

@@ -494 +494 @@
 
     stringImpl->ref();
+    wrapper.MarkIndependent();
     wrapper.MakeWeak(stringImpl, cachedStringCallback);
     m_stringCache.set(stringImpl, *wrapper);