Changeset 122618 in webkit

Timestamp:

Jul 13, 2012 12:11:12 PM (12 years ago)

Author:

dpranke@chromium.org

Message:

webkitpy: make worker.start() and worker.stop() optional in the messagepool
​https://bugs.webkit.org/show_bug.cgi?id=91170

Reviewed by Ojan Vafai.

test-webkitpy will use messagepool workers that don't actually
have any per-worker state, so they don't need start() and stop()
methods. Now we will only call the methods if they exist; this
means that workers only need to expose a handle() method.

• Scripts/webkitpy/common/message_pool.py:

(_Worker.terminate):
(_Worker.run):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/message_pool.py (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-07-13  Dirk Pranke  <dpranke@chromium.org>
+
+        webkitpy: make worker.start() and worker.stop() optional in the messagepool
+        https://bugs.webkit.org/show_bug.cgi?id=91170
+
+        Reviewed by Ojan Vafai.
+
+        test-webkitpy will use messagepool workers that don't actually
+        have any per-worker state, so they don't need start() and stop()
+        methods. Now we will only call the methods if they exist; this
+        means that workers only need to expose a handle() method.
+
+        * Scripts/webkitpy/common/message_pool.py:
+        (_Worker.terminate):
+        (_Worker.run):
+
 2012-07-13  Dirk Pranke  <dpranke@chromium.org>
 

trunk/Tools/Scripts/webkitpy/common/message_pool.py

@@ -210 +210 @@
     def terminate(self):
         if self._worker:
-            self._worker.stop()
+            if hasattr(self._worker, 'stop'):
+                self._worker.stop()
             self._worker = None
         if self.is_alive():
@@ -236 +237 @@
 
         try:
-            worker.start()
+            if hasattr(worker, 'start'):
+                worker.start()
             while True:
                 message = self._messages_to_worker.get()
@@ -255 +257 @@
         finally:
             try:
-                worker.stop()
+                if hasattr(worker, 'stop'):
+                    worker.stop()
             finally:
                 self._post(name='done', args=(), from_user=False)