Changeset 122655 in webkit


Ignore:
Timestamp:
Jul 13, 2012 7:03:21 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Remove Widget from screenColorProfile
​https://bugs.webkit.org/show_bug.cgi?id=91300

Patch by Tony Payne <​tpayne@chromium.org> on 2012-07-13
Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/Platform.h:

(Platform): Updated comment to reflect that we no longer have a type param.

Source/WebCore:

Chromium, the only platform implementing screenColorProfile, does not
need the Widget, so removing for simplicity.

Covered by existing tests.

  • platform/PlatformScreen.h:

(WebCore): Updated comment to remove reference to type param that no
longer exists and removed Widget param.

  • platform/blackberry/PlatformScreenBlackBerry.cpp:

(WebCore::screenColorProfile): Removed widget param.

  • platform/chromium/PlatformScreenChromium.cpp:

(WebCore::screenColorProfile): Removed widget param.

  • platform/efl/PlatformScreenEfl.cpp:

(WebCore::screenColorProfile): Removed widget param.

  • platform/gtk/PlatformScreenGtk.cpp:

(WebCore::screenColorProfile): Removed widget param.

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageDecoder::qcmsOutputDeviceProfile): removed param to
match screenColorProfile()'s new spec.

  • platform/mac/PlatformScreenMac.mm:

(WebCore::screenColorProfile): Removed widget param.

  • platform/qt/PlatformScreenQt.cpp:

(WebCore::screenColorProfile): Removed widget param.

  • platform/win/PlatformScreenWin.cpp:

(WebCore::screenColorProfile): Removed widget param.

Location:
trunk/Source
Files:
12 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/Platform/ChangeLog

    r122383 r122655  
     12012-07-13  Tony Payne  <tpayne@chromium.org>
     2
     3        Remove Widget from screenColorProfile
     4        https://bugs.webkit.org/show_bug.cgi?id=91300
     5
     6        Reviewed by Adam Barth.
     7
     8        * chromium/public/Platform.h:
     9        (Platform): Updated comment to reflect that we no longer have a type param.
     10
    1112012-07-11  Alexandre Elias  <aelias@google.com>
    212

  • trunk/Source/Platform/chromium/public/Platform.h

    r121600 r122655  
    243243    // Screen -------------------------------------------------------------
    244244
    245     // Supplies the system monitor color profile ("monitor") or a named ICC profile.
     245    // Supplies the system monitor color profile.
    246246    virtual void screenColorProfile(WebVector<char>* profile) { }
    247247

  • trunk/Source/WebCore/ChangeLog

    r122654 r122655  
     12012-07-13  Tony Payne  <tpayne@chromium.org>
     2
     3        Remove Widget from screenColorProfile
     4        https://bugs.webkit.org/show_bug.cgi?id=91300
     5
     6        Reviewed by Adam Barth.
     7
     8        Chromium, the only platform implementing screenColorProfile, does not
     9        need the Widget, so removing for simplicity.
     10
     11        Covered by existing tests.
     12
     13        * platform/PlatformScreen.h:
     14        (WebCore): Updated comment to remove reference to type param that no
     15        longer exists and removed Widget param.
     16        * platform/blackberry/PlatformScreenBlackBerry.cpp:
     17        (WebCore::screenColorProfile): Removed widget param.
     18        * platform/chromium/PlatformScreenChromium.cpp:
     19        (WebCore::screenColorProfile): Removed widget param.
     20        * platform/efl/PlatformScreenEfl.cpp:
     21        (WebCore::screenColorProfile): Removed widget param.
     22        * platform/gtk/PlatformScreenGtk.cpp:
     23        (WebCore::screenColorProfile): Removed widget param.
     24        * platform/image-decoders/ImageDecoder.h:
     25        (WebCore::ImageDecoder::qcmsOutputDeviceProfile): removed param to
     26        match screenColorProfile()'s new spec.
     27        * platform/mac/PlatformScreenMac.mm:
     28        (WebCore::screenColorProfile): Removed widget param.
     29        * platform/qt/PlatformScreenQt.cpp:
     30        (WebCore::screenColorProfile): Removed widget param.
     31        * platform/win/PlatformScreenWin.cpp:
     32        (WebCore::screenColorProfile): Removed widget param.
     33
    1342012-07-13  Brian Anderson  <brianderson@chromium.org>
    235

  • trunk/Source/WebCore/platform/PlatformScreen.h

    r121600 r122655  
    5353    FloatRect screenRect(Widget*);
    5454    FloatRect screenAvailableRect(Widget*);
    55     // type can be "monitor" or the name of a profile such as "sRGB" or "Adobe RGB".
    56     void screenColorProfile(Widget*, ColorProfile&);
     55    void screenColorProfile(ColorProfile&);
    5756
    5857#if PLATFORM(MAC)

  • trunk/Source/WebCore/platform/blackberry/PlatformScreenBlackBerry.cpp

    r121600 r122655  
    6565}
    6666
    67 void screenColorProfile(Widget*, ColorProfile&)
     67void screenColorProfile(ColorProfile&)
    6868{
    6969    notImplemented();

  • trunk/Source/WebCore/platform/chromium/PlatformScreenChromium.cpp

    r121600 r122655  
    7474}
    7575
    76 void screenColorProfile(Widget*, ColorProfile& toProfile)
     76void screenColorProfile(ColorProfile& toProfile)
    7777{
    78     // FIXME: Add support for multiple monitors.
    7978    WebKit::WebVector<char> profile;
    8079    WebKit::Platform::current()->screenColorProfile(&profile);

  • trunk/Source/WebCore/platform/efl/PlatformScreenEfl.cpp

    r122134 r122655  
    101101}
    102102
    103 void screenColorProfile(Widget*, ColorProfile&)
     103void screenColorProfile(ColorProfile&)
    104104{
    105105    notImplemented();

  • trunk/Source/WebCore/platform/gtk/PlatformScreenGtk.cpp

    r121600 r122655  
    138138}
    139139
    140 void screenColorProfile(Widget*, ColorProfile&)
     140void screenColorProfile(ColorProfile&)
    141141{
    142142    notImplemented();

  • trunk/Source/WebCore/platform/image-decoders/ImageDecoder.h

    r121600 r122655  
    316316                // FIXME: add support for multiple monitors.
    317317                ColorProfile profile;
    318                 screenColorProfile(0, profile);
     318                screenColorProfile(profile);
    319319                if (!profile.isEmpty())
    320320                    outputDeviceProfile = qcms_profile_from_memory(profile.data(), profile.size());

  • trunk/Source/WebCore/platform/mac/PlatformScreenMac.mm

    r121600 r122655  
    7777}
    7878
    79 void screenColorProfile(Widget*, ColorProfile&)
     79void screenColorProfile(ColorProfile&)
    8080{
    8181    notImplemented();

  • trunk/Source/WebCore/platform/qt/PlatformScreenQt.cpp

    r121600 r122655  
    144144}
    145145
    146 void screenColorProfile(Widget*, ColorProfile&)
     146void screenColorProfile(ColorProfile&)
    147147{
    148148    notImplemented();

  • trunk/Source/WebCore/platform/win/PlatformScreenWin.cpp

    r121600 r122655  
    119119}
    120120
    121 void screenColorProfile(Widget*, ColorProfile&)
     121void screenColorProfile(ColorProfile&)
    122122{
    123123    notImplemented();
Note: See TracChangeset for help on using the changeset viewer.