Changeset 123070 in webkit


Ignore:
Timestamp:
Jul 18, 2012 10:05:09 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Shadow DOM drop event tests are very flaky.
​https://bugs.webkit.org/show_bug.cgi?id=87364

Patch by Takashi Sakamoto <​tasak@google.com> on 2012-07-18
Reviewed by Hajime Morita.

Modified these tests to run test functions in onload. Probably
executing event tests while parsing html document causes flakyness.

  • fast/dom/shadow/drop-event-for-input-in-shadow.html:
  • fast/dom/shadow/drop-event-in-shadow.html:
  • platform/chromium/TestExpectations:
Location:
trunk/LayoutTests
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r123067 r123070  
     12012-07-18  Takashi Sakamoto  <tasak@google.com>
     2
     3        Shadow DOM drop event tests are very flaky.
     4        https://bugs.webkit.org/show_bug.cgi?id=87364
     5
     6        Reviewed by Hajime Morita.
     7
     8        Modified these tests to run test functions in onload. Probably
     9        executing event tests while parsing html document causes flakyness.
     10
     11        * fast/dom/shadow/drop-event-for-input-in-shadow.html:
     12        * fast/dom/shadow/drop-event-in-shadow.html:
     13        * platform/chromium/TestExpectations:
     14
    1152012-07-18  Hironori Bono  <hbono@chromium.org>
    216

  • trunk/LayoutTests/fast/dom/shadow/drop-event-for-input-in-shadow.html

    r118298 r123070  
    55<script src="../resources/event-sender-util.js"></script>
    66<script src="../../js/resources/js-test-pre.js"></script>
    7 </head>
    8 <body>
    9 
    10 <div id="host"></div>
    11 <pre id="console"></pre>
    12 
    137<script>
    148function createInput(name) {
    … …  
    2418}
    2519
    26 var shadowRoot = new WebKitShadowRoot(host);
    27 var shadowInput = createInput('shadow');
    28 shadowRoot.appendChild(shadowInput);
     20function runTest() {
     21    var shadowRoot = new WebKitShadowRoot(host);
     22    var shadowInput = createInput('shadow');
     23    shadowRoot.appendChild(shadowInput);
    2924
    30 eventSender.beginDragWithFiles(["../resources/apple.gif"]);
    31 mouseMoveToElem(shadowInput);
    32 eventSender.mouseUp();
     25    eventSender.beginDragWithFiles(["../resources/apple.gif"]);
     26    mouseMoveToElem(shadowInput);
     27    eventSender.mouseUp();
     28}
     29</script>
     30</head>
     31<body onload="runTest()">
    3332
    34 var successfullyParsed = true;
    35 </script>
    36 
    37 <script src="../../js/resources/js-test-post.js"></script>
     33<div id="host"></div>
     34<pre id="console"></pre>
    3835</body>
    3936</html>

  • trunk/LayoutTests/fast/dom/shadow/drop-event-in-shadow.html

    r118298 r123070  
    55<script src="../resources/event-sender-util.js"></script>
    66<script src="../../js/resources/js-test-pre.js"></script>
    7 </head>
    8 <body>
    9 
    10 <div id="host"></div>
    11 <pre id="console"></pre>
    12 
    137<script>
    148function createBox(name) {
    … …  
    2418}
    2519
    26 var shadowRoot = new WebKitShadowRoot(host);
    27 var shadowDiv = createBox('shadow');
    28 shadowRoot.appendChild(shadowDiv);
     20function runTest() {
     21    var shadowRoot = new WebKitShadowRoot(host);
     22    var shadowDiv = createBox('shadow');
     23    shadowRoot.appendChild(shadowDiv);
    2924
    30 eventSender.beginDragWithFiles(["../resources/apple.gif"]);
    31 mouseMoveToElem(shadowDiv);
    32 eventSender.mouseUp();
     25    eventSender.beginDragWithFiles(["../resources/apple.gif"]);
     26    mouseMoveToElem(shadowDiv);
     27    eventSender.mouseUp();
     28}
     29</script>
     30</head>
     31<body onload="runTest()">
    3332
    34 var successfullyParsed = true;
    35 </script>
    36 
    37 <script src="../../js/resources/js-test-post.js"></script>
     33<div id="host"></div>
     34<pre id="console"></pre>
    3835</body>
    3936</html>

  • trunk/LayoutTests/platform/chromium/TestExpectations

    r123067 r123070  
    35033503BUGWK79540 DEBUG : fast/files/workers/worker-read-blob-sync.html = PASS CRASH
    35043504
    3505 // Shadow DOM drop event tests are very flaky since creation
    3506 BUGWK87364 DEBUG : fast/dom/shadow/drop-event-for-input-in-shadow.html = TEXT PASS
    3507 BUGWK87364 DEBUG : fast/dom/shadow/drop-event-in-shadow.html = TEXT PASS
    3508 
    35093505// Requires setUseDeferredFrameLoading() API from LayoutTestController.
    35103506BUGWK87652 SKIP : http/tests/appcache/load-from-appcache-defer-resume-crash.html = PASS
Note: See TracChangeset for help on using the changeset viewer.