Changeset 123379 in webkit
- Timestamp:
- Jul 23, 2012 2:03:45 PM (12 years ago)
- Location:
- trunk
- Files:
-
- 5 added
- 17 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r123378 r123379 1 2012-07-23 Simon Fraser <simon.fraser@apple.com> 2 3 Part 2 of: Implement sticky positioning 4 https://bugs.webkit.org/show_bug.cgi?id=90046 5 6 Reviewed by Ojan Vafai. 7 8 Test for parsing and returning fro getComputedStyle() the new 9 -webkit-sticky value for position. 10 11 * fast/css/sticky/parsing-position-sticky-expected.txt: Added. 12 * fast/css/sticky/parsing-position-sticky.html: Added. 13 * fast/css/sticky/resources/parsing-position-sticky.js: Added. 14 (test): 15 1 16 2012-07-23 Andrew Wilson <atwilson@chromium.org> 2 17 -
trunk/Source/JavaScriptCore/ChangeLog
r123376 r123379 1 2012-07-23 Simon Fraser <simon.fraser@apple.com> 2 3 Part 2 of: Implement sticky positioning 4 https://bugs.webkit.org/show_bug.cgi?id=90046 5 6 Reviewed by Ojan Vafai. 7 8 Turn on ENABLE_CSS_STICKY_POSITION. 9 10 * Configurations/FeatureDefines.xcconfig: 11 1 12 2012-07-23 Patrick Gansterer <paroga@webkit.org> 2 13 -
trunk/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
r123350 r123379 44 44 ENABLE_CSS_REGIONS = ENABLE_CSS_REGIONS; 45 45 ENABLE_CSS_SHADERS = ENABLE_CSS_SHADERS; 46 ENABLE_CSS_STICKY_POSITION = ;46 ENABLE_CSS_STICKY_POSITION = ENABLE_CSS_STICKY_POSITION; 47 47 ENABLE_CSS_VARIABLES = ; 48 48 ENABLE_CSS3_FLEXBOX = ENABLE_CSS3_FLEXBOX; -
trunk/Source/WebCore/ChangeLog
r123377 r123379 1 2012-07-23 Simon Fraser <simon.fraser@apple.com> 2 3 Part 2 of: Implement sticky positioning 4 https://bugs.webkit.org/show_bug.cgi?id=90046 5 6 Reviewed by Ojan Vafai. 7 8 Turn on ENABLE_CSS_STICKY_POSITION. Add support for parsing the new '-webkit-sticky' 9 value for position, returning it from getComputedStyle(), and storing it in RenderStyle. 10 11 Test: fast/css/sticky/parsing-position-sticky.html 12 13 * Configurations/FeatureDefines.xcconfig: 14 * css/CSSComputedStyleDeclaration.cpp: 15 (WebCore::getPositionOffsetValue): 16 * css/CSSParser.cpp: 17 (WebCore::isValidKeywordPropertyAndValue): 18 * css/CSSPrimitiveValueMappings.h: 19 (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): 20 (WebCore::CSSPrimitiveValue::operator EPosition): 21 * css/CSSValueKeywords.in: 22 * rendering/style/RenderStyle.h: 23 * rendering/style/RenderStyleConstants.h: 24 1 25 2012-07-23 Stephen Chenney <schenney@chromium.org> 2 26 -
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
r123350 r123379 44 44 ENABLE_CSS_REGIONS = ENABLE_CSS_REGIONS; 45 45 ENABLE_CSS_SHADERS = ENABLE_CSS_SHADERS; 46 ENABLE_CSS_STICKY_POSITION = ;46 ENABLE_CSS_STICKY_POSITION = ENABLE_CSS_STICKY_POSITION; 47 47 ENABLE_CSS_VARIABLES = ; 48 48 ENABLE_CSS3_FLEXBOX = ENABLE_CSS3_FLEXBOX; -
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
r122895 r123379 609 609 } 610 610 611 if (style->position() == RelativePosition ) {611 if (style->position() == RelativePosition || style->position() == StickyPosition) { 612 612 // FIXME: It's not enough to simply return "auto" values for one offset if the other side is defined. 613 613 // In other words if left is auto and right is not auto, then left's computed value is negative right(). -
trunk/Source/WebCore/css/CSSParser.cpp
r123135 r123379 616 616 return true; 617 617 break; 618 case CSSPropertyPosition: // static | relative | absolute | fixed | inherit 619 if (valueID == CSSValueStatic || valueID == CSSValueRelative || valueID == CSSValueAbsolute || valueID == CSSValueFixed) 618 case CSSPropertyPosition: // static | relative | absolute | fixed | sticky | inherit 619 if (valueID == CSSValueStatic || valueID == CSSValueRelative || valueID == CSSValueAbsolute || valueID == CSSValueFixed 620 #if ENABLE(CSS_STICKY_POSITION) 621 || valueID == CSSValueWebkitSticky 622 #endif 623 ) 620 624 return true; 621 625 break; -
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
r123300 r123379 2033 2033 m_value.ident = CSSValueFixed; 2034 2034 break; 2035 #if ENABLE(CSS_STICKY_POSITION) 2036 case StickyPosition: 2037 m_value.ident = CSSValueWebkitSticky; 2038 break; 2039 #endif 2035 2040 } 2036 2041 } … … 2047 2052 case CSSValueFixed: 2048 2053 return FixedPosition; 2054 #if ENABLE(CSS_STICKY_POSITION) 2055 case CSSValueWebkitSticky: 2056 return StickyPosition; 2057 #endif 2049 2058 default: 2050 2059 ASSERT_NOT_REACHED(); -
trunk/Source/WebCore/css/CSSValueKeywords.in
r121127 r123379 916 916 edges 917 917 918 // position 919 #if defined(ENABLE_CSS_STICKY_POSITION) && ENABLE_CSS_STICKY_POSITION 920 -webkit-sticky 921 #endif // CSS_STICKY_POSITION 922 918 923 // (pointer:) media feature 919 924 // none -
trunk/Source/WebCore/rendering/style/RenderStyle.h
r122895 r123379 305 305 unsigned _vertical_align : 4; // EVerticalAlign 306 306 unsigned _clear : 2; // EClear 307 unsigned _position : 2; // EPosition307 unsigned _position : 3; // EPosition 308 308 unsigned _floating : 2; // EFloat 309 309 unsigned _table_layout : 1; // ETableLayout … … 332 332 unsigned _isLink : 1; 333 333 // If you add more style bits here, you will also need to update RenderStyle::copyNonInheritedFrom() 334 // 5 3bits334 // 54 bits 335 335 } noninherited_flags; 336 336 -
trunk/Source/WebCore/rendering/style/RenderStyleConstants.h
r121127 r123379 95 95 96 96 enum EPosition { 97 StaticPosition, RelativePosition, AbsolutePosition, FixedPosition 97 StaticPosition, RelativePosition, AbsolutePosition, FixedPosition, StickyPosition 98 98 }; 99 99 -
trunk/Source/WebKit/chromium/ChangeLog
r123375 r123379 1 2012-07-23 Simon Fraser <simon.fraser@apple.com> 2 3 Part 2 of: Implement sticky positioning 4 https://bugs.webkit.org/show_bug.cgi?id=90046 5 6 Reviewed by Ojan Vafai. 7 8 Turn on ENABLE_CSS_STICKY_POSITION. 9 10 * features.gypi: 11 1 12 2012-07-23 Shawn Singh <shawnsingh@chromium.org> 2 13 -
trunk/Source/WebKit/chromium/features.gypi
r123350 r123379 48 48 'ENABLE_CSS_SHADERS=1', 49 49 'ENABLE_CSS_VARIABLES=1', 50 'ENABLE_CSS_STICKY_POSITION= 0',50 'ENABLE_CSS_STICKY_POSITION=1', 51 51 'ENABLE_CUSTOM_SCHEME_HANDLER=0', 52 52 'ENABLE_DATALIST_ELEMENT=1', -
trunk/Source/WebKit/mac/ChangeLog
r123354 r123379 1 2012-07-23 Simon Fraser <simon.fraser@apple.com> 2 3 Part 2 of: Implement sticky positioning 4 https://bugs.webkit.org/show_bug.cgi?id=90046 5 6 Reviewed by Ojan Vafai. 7 8 Turn on ENABLE_CSS_STICKY_POSITION. 9 10 * Configurations/FeatureDefines.xcconfig: 11 1 12 2012-07-23 Pierre Rossi <pierre.rossi@gmail.com> 2 13 -
trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
r123350 r123379 45 45 ENABLE_CSS_REGIONS = ENABLE_CSS_REGIONS; 46 46 ENABLE_CSS_SHADERS = ENABLE_CSS_SHADERS; 47 ENABLE_CSS_STICKY_POSITION = ;47 ENABLE_CSS_STICKY_POSITION = ENABLE_CSS_STICKY_POSITION; 48 48 ENABLE_CSS_VARIABLES = ; 49 49 ENABLE_CSS3_FLEXBOX = ENABLE_CSS3_FLEXBOX; -
trunk/Source/WebKit2/ChangeLog
r123374 r123379 1 2012-07-23 Simon Fraser <simon.fraser@apple.com> 2 3 Part 2 of: Implement sticky positioning 4 https://bugs.webkit.org/show_bug.cgi?id=90046 5 6 Reviewed by Ojan Vafai. 7 8 Turn on ENABLE_CSS_STICKY_POSITION. 9 10 * Configurations/FeatureDefines.xcconfig: 11 1 12 2012-07-23 Christophe Dumez <christophe.dumez@intel.com> 2 13 -
trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig
r123350 r123379 45 45 ENABLE_CSS_REGIONS = ENABLE_CSS_REGIONS; 46 46 ENABLE_CSS_SHADERS = ENABLE_CSS_SHADERS; 47 ENABLE_CSS_STICKY_POSITION = ;47 ENABLE_CSS_STICKY_POSITION = ENABLE_CSS_STICKY_POSITION; 48 48 ENABLE_CSS_VARIABLES = ; 49 49 ENABLE_CSS3_FLEXBOX = ENABLE_CSS3_FLEXBOX;
Note: See TracChangeset
for help on using the changeset viewer.