Changeset 123556 in webkit

Timestamp:

Jul 24, 2012 5:37:11 PM (12 years ago)

Author:

kbr@google.com

Message:

[chromium] Hint garbage collector to run if page uses Canvas contexts
​https://bugs.webkit.org/show_bug.cgi?id=76225

Reviewed by Kentaro Hara.

Source/WebCore:

Upon creating a canvas context, set a hint in the current isolate
indicating that a full GC should be done upon the next page
navigation.

This improves Chrome's robustness on some WebGL stress tests which
simulate real-world behavior by repeatedly navigating among
several samples. More general measures are being investigated, but
this change makes V8 behave the same as JSC on these stress tests.
JSC doesn't currently use generational garbage collection, so it
has more opportunities to discover unreferenced canvas contexts.

Test: fast/canvas/webgl/context-creation-and-destruction.html

• bindings/v8/V8Binding.cpp:

(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):

Initialize per-isolate low memory hint.

• bindings/v8/V8Binding.h:

(V8BindingPerIsolateData):
(WebCore::V8BindingPerIsolateData::setLowMemoryNotificationHint):

Set a per-isolate hint to signal a low memory condition upon the next page navigation.

(WebCore::V8BindingPerIsolateData::clearLowMemoryNotificationHint):

Clear the previously set hint.

(WebCore::V8BindingPerIsolateData::isLowMemoryNotificationHint):

Get the previously set hint.

• bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::hintForGCIfNecessary):

If necessary, send V8 a hint that it should GC.

(WebCore):
(WebCore::V8Proxy::clearForClose):
(WebCore::V8Proxy::clearForNavigation):

Call hintForGCIfNecessary.

• bindings/v8/V8Proxy.h:

(V8Proxy):

• bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

Set a hint that we should GC upon the next page navigation.

LayoutTests:

This test doesn't directly exercise this code path yet, but it
needs to work regardless and also needs to be expanded.

• fast/canvas/webgl/context-creation-and-destruction-expected.txt: Added.
• fast/canvas/webgl/context-creation-and-destruction.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/canvas/webgl/context-creation-and-destruction-expected.txt (added)
• LayoutTests/fast/canvas/webgl/context-creation-and-destruction.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/bindings/v8/V8Binding.cpp (modified) (1 diff)
• Source/WebCore/bindings/v8/V8Binding.h (modified) (2 diffs)
• Source/WebCore/bindings/v8/V8Proxy.cpp (modified) (2 diffs)
• Source/WebCore/bindings/v8/V8Proxy.h (modified) (1 diff)
• Source/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-07-24  Kenneth Russell  <kbr@google.com>
+
+        [chromium] Hint garbage collector to run if page uses Canvas contexts
+        https://bugs.webkit.org/show_bug.cgi?id=76225
+
+        Reviewed by Kentaro Hara.
+
+        This test doesn't directly exercise this code path yet, but it
+        needs to work regardless and also needs to be expanded.
+
+        * fast/canvas/webgl/context-creation-and-destruction-expected.txt: Added.
+        * fast/canvas/webgl/context-creation-and-destruction.html: Added.
+
 2012-07-24  Alexis Menard  <alexis.menard@openbossa.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-07-24  Kenneth Russell  <kbr@google.com>
+
+        [chromium] Hint garbage collector to run if page uses Canvas contexts
+        https://bugs.webkit.org/show_bug.cgi?id=76225
+
+        Reviewed by Kentaro Hara.
+
+        Upon creating a canvas context, set a hint in the current isolate
+        indicating that a full GC should be done upon the next page
+        navigation.
+
+        This improves Chrome's robustness on some WebGL stress tests which
+        simulate real-world behavior by repeatedly navigating among
+        several samples. More general measures are being investigated, but
+        this change makes V8 behave the same as JSC on these stress tests.
+        JSC doesn't currently use generational garbage collection, so it
+        has more opportunities to discover unreferenced canvas contexts.
+
+        Test: fast/canvas/webgl/context-creation-and-destruction.html
+
+        * bindings/v8/V8Binding.cpp:
+        (WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):
+            Initialize per-isolate low memory hint.
+        * bindings/v8/V8Binding.h:
+        (V8BindingPerIsolateData):
+        (WebCore::V8BindingPerIsolateData::setLowMemoryNotificationHint):
+            Set a per-isolate hint to signal a low memory condition upon the next page navigation.
+        (WebCore::V8BindingPerIsolateData::clearLowMemoryNotificationHint):
+            Clear the previously set hint.
+        (WebCore::V8BindingPerIsolateData::isLowMemoryNotificationHint):
+            Get the previously set hint.
+        * bindings/v8/V8Proxy.cpp:
+        (WebCore::V8Proxy::hintForGCIfNecessary):
+            If necessary, send V8 a hint that it should GC.
+        (WebCore):
+        (WebCore::V8Proxy::clearForClose):
+        (WebCore::V8Proxy::clearForNavigation):
+            Call hintForGCIfNecessary.
+        * bindings/v8/V8Proxy.h:
+        (V8Proxy):
+        * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
+        (WebCore::V8HTMLCanvasElement::getContextCallback):
+            Set a hint that we should GC upon the next page navigation.
+
 2012-07-24  Dave Tu  <dtu@chromium.org>
 

trunk/Source/WebCore/bindings/v8/V8Binding.cpp

@@ -61 +61 @@
     , m_internalScriptRecursionLevel(0)
 #endif
+    , m_lowMemoryNotificationHint(false)
 {
 }

trunk/Source/WebCore/bindings/v8/V8Binding.h

@@ -221 +221 @@
         void reportMemoryUsage(MemoryObjectInfo*) const;
 
+        // Gives the system a hint that we should send a low memory
+        // notification upon the next close or navigation event,
+        // because some expensive objects have been allocated that we
+        // want to take every opportunity to collect.
+        void setLowMemoryNotificationHint() { m_lowMemoryNotificationHint = true; }
+        void clearLowMemoryNotificationHint() { m_lowMemoryNotificationHint = false; }
+        bool isLowMemoryNotificationHint() const { return m_lowMemoryNotificationHint; }
+
     private:
         explicit V8BindingPerIsolateData(v8::Isolate*);
@@ -249 +257 @@
 #endif
         GCEventData m_gcEventData;
+
+        bool m_lowMemoryNotificationHint;
     };
 

trunk/Source/WebCore/bindings/v8/V8Proxy.cpp

@@ -560 +560 @@
 }
 
+void V8Proxy::hintForGCIfNecessary()
+{
+    V8BindingPerIsolateData* data = V8BindingPerIsolateData::current();
+    if (data->isLowMemoryNotificationHint()) {
+        data->clearLowMemoryNotificationHint();
+        v8::V8::LowMemoryNotification();
+    }
+}
+
 void V8Proxy::clearForClose()
 {
     resetIsolatedWorlds();
+    hintForGCIfNecessary();
     windowShell()->clearForClose();
 }
@@ -569 +579 @@
 {
     resetIsolatedWorlds();
+    hintForGCIfNecessary();
     windowShell()->clearForNavigation();
 }

trunk/Source/WebCore/bindings/v8/V8Proxy.h

@@ -272 +272 @@
         void resetIsolatedWorlds();
 
+        void hintForGCIfNecessary();
+
         PassOwnPtr<v8::ScriptData> precompileScript(v8::Handle<v8::String>, CachedScript*);
 

trunk/Source/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp

@@ -87 +87 @@
     if (!result)
         return v8::Null(args.GetIsolate());
+
+    // Both 2D and 3D canvas contexts can hold on to lots of GPU resources, and we
+    // want to take an opportunity to get rid of them as soon as possible when we
+    // navigate away from pages using them.
+    V8BindingPerIsolateData* perIsolateData = V8BindingPerIsolateData::current(args.GetIsolate());
+    perIsolateData->setLowMemoryNotificationHint();
+
     if (result->is2d())
         return toV8(static_cast<CanvasRenderingContext2D*>(result), args.GetIsolate());