Changeset 124366 in webkit


Ignore:
Timestamp:
Aug 1, 2012 2:02:56 PM (12 years ago)
Author:
rniwa@webkit.org
Message:

run-perf-tests --build-directory doesn't work
https://bugs.webkit.org/show_bug.cgi?id=92051

Reviewed by Dirk Pranke.

The bug was caused by not prepending build_directory even when one is defined.
Fixed that.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port._build_path):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_build_path):

Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r124354 r124366  
     12012-08-01  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        run-perf-tests --build-directory doesn't work
     4        https://bugs.webkit.org/show_bug.cgi?id=92051
     5
     6        Reviewed by Dirk Pranke.
     7
     8        The bug was caused by not prepending build_directory even when one is defined.
     9        Fixed that.
     10
     11        * Scripts/webkitpy/layout_tests/port/base.py:
     12        (Port._build_path):
     13        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
     14        (PortTest.test_build_path):
     15
    1162012-08-01  Sheriff Bot  <webkit.review.bot@gmail.com>
    217
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py

    r124319 r124366  
    11521152            build_directory = self.get_option('build_directory')
    11531153            if build_directory:
    1154                 root_directory = self._filesystem.join(self.get_option('configuration'))
     1154                root_directory = self._filesystem.join(build_directory, self.get_option('configuration'))
    11551155            else:
    11561156                root_directory = self._config.build_directory(self.get_option('configuration'))
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

    r123614 r124366  
    438438        self.assertTrue('virtual/passes/text.html' in tests)
    439439
     440    def test_build_path(self):
     441        port = self.make_port(options=optparse.Values({'build_directory': '/my-build-directory/'}))
     442        self.assertEqual(port._build_path(), '/my-build-directory/Release')
     443
    440444
    441445if __name__ == '__main__':
Note: See TracChangeset for help on using the changeset viewer.