Changeset 124461 in webkit

Timestamp:

Aug 2, 2012 9:03:46 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL][WK2]Add ewk_view_ui_client.
​https://bugs.webkit.org/show_bug.cgi?id=89864

Patch by Hyerim Bae <​hyerim.bae@samsung.com> on 2012-08-02
Reviewed by Kentaro Hara.

Add ewk_view_ui_client.h / cpp files for wrapping WKPageSetPageUIClient,
add close, createNewPage callback member to WKPageSetPageUIClient.

• PlatformEfl.cmake:
• UIProcess/API/efl/ewk_view.cpp:

(ewk_view_base_add):
(ewk_view_page_close):
(ewk_view_page_create):

• UIProcess/API/efl/ewk_view.h:
• UIProcess/API/efl/ewk_view_private.h:
• UIProcess/API/efl/ewk_view_ui_client.cpp: Added.

(toEwkView):
(closePage):
(createNewPage):
(ewk_view_ui_client_attach):

• UIProcess/API/efl/ewk_view_ui_client_private.h: Added.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• PlatformEfl.cmake (modified) (1 diff)
• UIProcess/API/efl/ewk_view.cpp (modified) (3 diffs)
• UIProcess/API/efl/ewk_view.h (modified) (1 diff)
• UIProcess/API/efl/ewk_view_private.h (modified) (1 diff)
• UIProcess/API/efl/ewk_view_ui_client.cpp (added)
• UIProcess/API/efl/ewk_view_ui_client_private.h (added)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2012-08-02  Hyerim Bae  <hyerim.bae@samsung.com>
+
+        [EFL][WK2]Add ewk_view_ui_client.
+        https://bugs.webkit.org/show_bug.cgi?id=89864
+
+        Reviewed by Kentaro Hara.
+
+        Add ewk_view_ui_client.h / cpp files for wrapping WKPageSetPageUIClient,
+        add close, createNewPage callback member to WKPageSetPageUIClient.
+
+        * PlatformEfl.cmake:
+        * UIProcess/API/efl/ewk_view.cpp:
+        (ewk_view_base_add):
+        (ewk_view_page_close):
+        (ewk_view_page_create):
+        * UIProcess/API/efl/ewk_view.h:
+        * UIProcess/API/efl/ewk_view_private.h:
+        * UIProcess/API/efl/ewk_view_ui_client.cpp: Added.
+        (toEwkView):
+        (closePage):
+        (createNewPage):
+        (ewk_view_ui_client_attach):
+        * UIProcess/API/efl/ewk_view_ui_client_private.h: Added.
+
 2012-08-02  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit2/PlatformEfl.cmake

@@ -60 +60 @@
     UIProcess/API/efl/ewk_view_policy_client.cpp
     UIProcess/API/efl/ewk_view_resource_load_client.cpp
+    UIProcess/API/efl/ewk_view_ui_client.cpp
     UIProcess/API/efl/ewk_web_error.cpp
     UIProcess/API/efl/ewk_web_resource.cpp

trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp

@@ -38 +38 @@
 #include "ewk_view_private.h"
 #include "ewk_view_resource_load_client_private.h"
+#include "ewk_view_ui_client_private.h"
 #include "ewk_web_resource.h"
 #include <Ecore_Evas.h>
@@ -668 +669 @@
     ewk_view_policy_client_attach(wkPage, ewkView);
     ewk_view_resource_load_client_attach(wkPage, ewkView);
+    ewk_view_ui_client_attach(wkPage, ewkView);
 
     ewk_view_theme_set(ewkView, DEFAULT_THEME_PATH"/default.edj");
@@ -1298 +1300 @@
     return true;
 }
+
+void ewk_view_page_close(Evas_Object* ewkView)
+{
+    evas_object_smart_callback_call(ewkView, "close,window", 0);
+}
+
+WKPageRef ewk_view_page_create(Evas_Object* ewkView)
+{
+    Evas_Object* newEwkView = 0;
+    evas_object_smart_callback_call(ewkView, "create,window", &newEwkView);
+
+    if (!newEwkView)
+        return 0;
+
+    return static_cast<WKPageRef>(WKRetain(ewk_view_page_get(newEwkView)));
+}

trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h

@@ -27 +27 @@
  * The following signals (see evas_object_smart_callback_add()) are emitted:
  *
+ * - "close,window", void: window is closed.
+ * - "create,window", Evas_Object**: a new window is created.
  * - "download,cancelled", Ewk_Download_Job*: reports that a download was effectively cancelled.
  * - "download,failed", Ewk_Download_Job_Error*: reports that a download failed with the given error.

trunk/Source/WebKit2/UIProcess/API/efl/ewk_view_private.h

@@ -62 +62 @@
 void ewk_view_navigation_policy_decision(Evas_Object* ewkView, Ewk_Navigation_Policy_Decision* decision);
 void ewk_view_new_window_policy_decision(Evas_Object* ewkView, Ewk_Navigation_Policy_Decision* decision);
+void ewk_view_page_close(Evas_Object* ewkView);
+WKPageRef ewk_view_page_create(Evas_Object* ewkView);
 void ewk_view_title_changed(Evas_Object* ewkView, const char* title);
 void ewk_view_resource_load_failed(Evas_Object* ewkView, uint64_t resourceIdentifier, Ewk_Web_Error* error);