Changeset 125371 in webkit
- Timestamp:
- Aug 12, 2012 4:38:09 AM (12 years ago)
- Location:
- trunk
- Files:
-
- 2 deleted
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r125354 r125371 1 2012-08-12 Takashi Sakamoto <tasak@google.com> 2 3 webkit fails IETC namespaces/prefix-007.xml 4 https://bugs.webkit.org/show_bug.cgi?id=86137 5 6 Reviewed by Eric Seidel. 7 8 * platform/chromium/TestExpectations: 9 Enabled the layout tests, ietestcenter/css3/namespaces/prefix-007.xml 10 and ietestcenter/css3/namespaces/prefix-010.xml. 11 * platform/win/ietestcenter/css3/namespaces/prefix-007-expected.txt: Removed. 12 * platform/win/ietestcenter/css3/namespaces/prefix-010-expected.txt: Removed. 13 Removed old expectations. 14 1 15 2012-08-11 Jon Lee <jonlee@apple.com> 2 16 -
trunk/LayoutTests/platform/chromium/TestExpectations
r125280 r125371 3130 3130 BUGWK85310 : ietestcenter/css3/valuesandunits/units-010.htm = IMAGE 3131 3131 // IETC namespace failures 3132 BUGWK86137 : ietestcenter/css3/namespaces/prefix-007.xml = IMAGE3133 BUGWK86139 : ietestcenter/css3/namespaces/prefix-010.xml = IMAGE3134 3132 BUGWK86142 : ietestcenter/css3/namespaces/syntax-021.xml = IMAGE 3135 3133 -
trunk/Source/WebCore/ChangeLog
r125368 r125371 1 2012-08-12 Takashi Sakamoto <tasak@google.com> 2 3 webkit fails IETC namespaces/prefix-007.xml 4 https://bugs.webkit.org/show_bug.cgi?id=86137 5 6 Reviewed by Eric Seidel. 7 8 If a namespace prefix or default namespace is declared more than once 9 only the last declaration shall be used. 10 11 parseAddNamespace doesn't check return value of WTF::HashMap<>::add. 12 If the return value's isNewEntry is true, the new entry is added with 13 the specified value. However, if isNewEntry is false, it is required 14 to update the store value. 15 16 No new tests. ietestcenter/css3/namespaces/prefix-007.xml and 17 ietestcenter/css3/namespaces/prefix-010.xml covers this change. 18 19 * css/StyleSheetContents.cpp: 20 (WebCore::StyleSheetContents::parserAddNamespace): 21 Modified to check m_namespaces.add's return value. 22 If the result says not a new entry, updated the value stored in 23 m_namespaces by using iterator in the result. 24 1 25 2012-08-12 Benjamin Poulain <benjamin@webkit.org> 2 26 -
trunk/Source/WebCore/css/StyleSheetContents.cpp
r125265 r125371 251 251 if (uri.isNull() || prefix.isNull()) 252 252 return; 253 m_namespaces.add(prefix, uri); 253 PrefixNamespaceURIMap::AddResult result = m_namespaces.add(prefix, uri); 254 if (result.isNewEntry) 255 return; 256 result.iterator->second = uri; 254 257 } 255 258
Note: See TracChangeset
for help on using the changeset viewer.