Changeset 125705 in webkit

Timestamp:

Aug 15, 2012 2:13:15 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[BlackBerry] Should not keep recreating GeoTracker in setEnableHighAccuracy()
​https://bugs.webkit.org/show_bug.cgi?id=94136

Patch by Yong Li <​yoli@rim.com> on 2012-08-15
Reviewed by Rob Buis.
Internally reviewed by Lyon Chen.

PR# 192401.

1. The prototype of GeoTracker::create() has changed.
2. Fix the issue that it could recreate tracker unnecessarily when setEnableHighAccuracy() is called but accuracy requirment hasn't changed.
3. Fix the issue setEnableHighAccuracy() could start tracking when tracker was suspended.

• WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:

(GeolocationControllerClientBlackBerry::startUpdating):
(GeolocationControllerClientBlackBerry::setEnableHighAccuracy):

Location:

trunk/Source/WebKit/blackberry

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/GeolocationControllerClientBlackBerry.cpp (modified) (2 diffs)

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2012-08-15  Yong Li  <yoli@rim.com>
+
+        [BlackBerry] Should not keep recreating GeoTracker in setEnableHighAccuracy()
+        https://bugs.webkit.org/show_bug.cgi?id=94136
+
+        Reviewed by Rob Buis.
+        Internally reviewed by Lyon Chen.
+
+        PR# 192401.
+        1. The prototype of GeoTracker::create() has changed.
+        2. Fix the issue that it could recreate tracker unnecessarily when
+           setEnableHighAccuracy() is called but accuracy requirment hasn't
+           changed.
+        3. Fix the issue setEnableHighAccuracy() could start tracking when
+           tracker was suspended.
+
+        * WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:
+        (GeolocationControllerClientBlackBerry::startUpdating):
+        (GeolocationControllerClientBlackBerry::setEnableHighAccuracy):
+
 2012-08-15  Mike Fenton  <mifenton@rim.com>
 

trunk/Source/WebKit/blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.cpp

@@ -48 +48 @@
         m_tracker->resume();
     else
-        m_tracker = BlackBerry::Platform::GeoTracker::create(this, 0, m_accuracy, -1, -1);
+        m_tracker = BlackBerry::Platform::GeoTracker::create(this, m_accuracy);
 }
 
@@ -102 +102 @@
     if (m_accuracy == newAccuracy)
         return;
-    if (m_tracker) {
-        m_tracker->destroy();
-        m_tracker = BlackBerry::Platform::GeoTracker::create(this, 0, newAccuracy, -1, -1);
-    }
+
+    m_accuracy = newAccuracy;
+
+    if (m_tracker)
+        m_tracker->setRequiresHighAccuracy(m_accuracy);
 }