Changeset 125985 in webkit

Timestamp:

Aug 19, 2012 6:31:23 PM (12 years ago)

Author:

haraken@chromium.org

Message:

Remove RefPtr from HTMLProgressElement::m_value
​https://bugs.webkit.org/show_bug.cgi?id=94336

Reviewed by Kent Tamura.

To avoid reference cycles of RefPtr<Node>s, we want to remove
unnecessary RefPtr<Node>s. The rationale is described in bug 94324.

HTMLProgressElement::m_value does not need to be a RefPtr<Node>, because
it is guaranteed to point to a shadow DOM tree of the HTMLProgressElement
node, which is guaranteed to exist in the subtree of the HTMLProgressElement node.

No tests. No change in behavior.

• html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::HTMLProgressElement):
(WebCore::HTMLProgressElement::createShadowSubtree):

• html/HTMLProgressElement.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLProgressElement.cpp (modified) (3 diffs)
• html/HTMLProgressElement.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-08-19  Kentaro Hara  <haraken@chromium.org>
+
+        Remove RefPtr from HTMLProgressElement::m_value
+        https://bugs.webkit.org/show_bug.cgi?id=94336
+
+        Reviewed by Kent Tamura.
+
+        To avoid reference cycles of RefPtr<Node>s, we want to remove
+        unnecessary RefPtr<Node>s. The rationale is described in bug 94324.
+
+        HTMLProgressElement::m_value does not need to be a RefPtr<Node>, because
+        it is guaranteed to point to a shadow DOM tree of the HTMLProgressElement
+        node, which is guaranteed to exist in the subtree of the HTMLProgressElement node.
+
+        No tests. No change in behavior.
+
+        * html/HTMLProgressElement.cpp:
+        (WebCore::HTMLProgressElement::HTMLProgressElement):
+        (WebCore::HTMLProgressElement::createShadowSubtree):
+        * html/HTMLProgressElement.h:
+
 2012-08-19  Kentaro Hara  <haraken@chromium.org>
 

trunk/Source/WebCore/html/HTMLProgressElement.cpp

@@ -44 +44 @@
 HTMLProgressElement::HTMLProgressElement(const QualifiedName& tagName, Document* document)
     : LabelableElement(tagName, document)
+    , m_value(0)
     , m_hasAuthorShadowRoot(false)
 {
@@ -165 +166 @@
 {
     ASSERT(!userAgentShadowRoot());
+    ASSERT(!m_value);
            
     RefPtr<ShadowRoot> root = ShadowRoot::create(this, ShadowRoot::UserAgentShadowRoot, ASSERT_NO_EXCEPTION);
@@ -172 +174 @@
 
     RefPtr<ProgressBarElement> bar = ProgressBarElement::create(document());
-    m_value = ProgressValueElement::create(document());
+    RefPtr<ProgressValueElement> value = ProgressValueElement::create(document());
+    m_value = value.get();
     bar->appendChild(m_value, ASSERT_NO_EXCEPTION);
 

trunk/Source/WebCore/html/HTMLProgressElement.h

@@ -72 +72 @@
     void createShadowSubtree();
 
-    RefPtr<ProgressValueElement> m_value;
+    ProgressValueElement* m_value;
     bool m_hasAuthorShadowRoot;
 };