Changeset 126123 in webkit

Timestamp:

Aug 20, 2012 7:47:21 PM (12 years ago)

Author:

haraken@chromium.org

Message:

Rename collectGarbageIfNecessary() to hintForCollectGarbage()
​https://bugs.webkit.org/show_bug.cgi?id=94455

Reviewed by Adam Barth.

This is a follow-up patch for r126098.

collectGarbage() always collects garbage. collectGarbageIfNecessary() just sends
an idle notification to V8, which is just a hint for V8 to trigger GC.
To clarify the difference, this patch renames collectGarbageIfNecessary()
to hintForCollectGarbage().

No tests. No change in behavior.

• bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::clearForClose):
(WebCore::ScriptController::clearForNavigation):

• bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::hintForCollectGarbage):

• bindings/v8/V8GCController.h:

(V8GCController):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/ScriptController.cpp (modified) (2 diffs)
• bindings/v8/V8GCController.cpp (modified) (1 diff)
• bindings/v8/V8GCController.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-08-20  Kentaro Hara  <haraken@chromium.org>
+
+        Rename collectGarbageIfNecessary() to hintForCollectGarbage()
+        https://bugs.webkit.org/show_bug.cgi?id=94455
+
+        Reviewed by Adam Barth.
+
+        This is a follow-up patch for r126098.
+
+        collectGarbage() always collects garbage. collectGarbageIfNecessary() just sends
+        an idle notification to V8, which is just a hint for V8 to trigger GC.
+        To clarify the difference, this patch renames collectGarbageIfNecessary()
+        to hintForCollectGarbage().
+
+        No tests. No change in behavior.
+
+        * bindings/v8/ScriptController.cpp:
+        (WebCore::ScriptController::clearForClose):
+        (WebCore::ScriptController::clearForNavigation):
+        * bindings/v8/V8GCController.cpp:
+        (WebCore::V8GCController::hintForCollectGarbage):
+        * bindings/v8/V8GCController.h:
+        (V8GCController):
+
 2012-08-20  Alexandre Elias  <aelias@google.com>
 

trunk/Source/WebCore/bindings/v8/ScriptController.cpp

@@ -166 +166 @@
 {
     resetIsolatedWorlds();
-    V8GCController::collectGarbageIfNecessary();
+    V8GCController::hintForCollectGarbage();
     windowShell()->clearForClose();
 }
@@ -173 +173 @@
 {
     resetIsolatedWorlds();
-    V8GCController::collectGarbageIfNecessary();
+    V8GCController::hintForCollectGarbage();
     windowShell()->clearForNavigation();
 }

trunk/Source/WebCore/bindings/v8/V8GCController.cpp

@@ -521 +521 @@
 }
 
-void V8GCController::collectGarbageIfNecessary()
+void V8GCController::hintForCollectGarbage()
 {
     V8PerIsolateData* data = V8PerIsolateData::current();

trunk/Source/WebCore/bindings/v8/V8GCController.h

@@ -77 +77 @@
 
         static void checkMemoryUsage();
-        static void collectGarbageIfNecessary();
+        static void hintForCollectGarbage();
         static void collectGarbage();