Changeset 126192 in webkit


Ignore:
Timestamp:
Aug 21, 2012 3:02:13 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6.html fails
​https://bugs.webkit.org/show_bug.cgi?id=50797

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-08-21
Reviewed by Andreas Kling.

Source/WebCore:

Add a check in fast-path parseAlphaValue() to return early
if the CSS <alphavalue> ended with an invalid digit.

Test: canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6.html

  • css/CSSParser.cpp:

(WebCore::parseAlphaValue):

LayoutTests:

Unskipped tests that are now passing after this fix and removed
wrong expectations.

  • platform/chromium/TestExpectations:
  • platform/chromium/canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6-expected.txt: Removed.
  • platform/efl/Skipped:
  • platform/gtk/TestExpectations:
  • platform/mac/canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6-expected.txt: Removed.
  • platform/qt/Skipped:
Location:
trunk
Files:
2 deleted
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r126190 r126192  
     12012-08-21  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
     2
     3        canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6.html fails
     4        https://bugs.webkit.org/show_bug.cgi?id=50797
     5
     6        Reviewed by Andreas Kling.
     7
     8        Unskipped tests that are now passing after this fix and removed
     9        wrong expectations.
     10
     11        * platform/chromium/TestExpectations:
     12        * platform/chromium/canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6-expected.txt: Removed.
     13        * platform/efl/Skipped:
     14        * platform/gtk/TestExpectations:
     15        * platform/mac/canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6-expected.txt: Removed.
     16        * platform/qt/Skipped:
     17
    1182012-08-21  Levi Weintraub  <leviw@chromium.org>
    219

  • trunk/LayoutTests/platform/chromium/TestExpectations

    r126190 r126192  
    18741874BUGWK45991 LINUX ANDROID WIN : platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.baseline.ideographic.html = TEXT
    18751875
    1876 BUGWK50797 : canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6.html = TEXT
    1877 BUGWK50797 : platform/chromium/virtual/gpu/canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6.html = TEXT
    1878 
    18791876// Update canvas/philip in WK r71481
    18801877BUGCR62301 : canvas/philip/tests/2d.drawImage.image.incomplete.omitted.html = TEXT

  • trunk/LayoutTests/platform/efl/Skipped

    r126027 r126192  
    306306canvas/philip/tests/2d.drawImage.broken.html
    307307canvas/philip/tests/2d.drawImage.image.incomplete.omitted.html
    308 canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6.html
    309308canvas/philip/tests/2d.fillStyle.parse.rgb-eof.html
    310309canvas/philip/tests/2d.fillStyle.parse.rgba-eof.html

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r126145 r126192  
    910910BUGWKGTK : canvas/philip/tests/2d.drawImage.broken.html = TEXT
    911911BUGWKGTK : canvas/philip/tests/2d.drawImage.image.incomplete.omitted.html = TEXT
    912 BUGWKGTK : canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6.html = TEXT
    913912BUGWKGTK : canvas/philip/tests/2d.fillStyle.parse.rgb-eof.html = TEXT
    914913BUGWKGTK : canvas/philip/tests/2d.fillStyle.parse.rgba-eof.html = TEXT

  • trunk/LayoutTests/platform/qt/Skipped

    r126161 r126192  
    21222122# Failing tests after sync with Philip Taylor's upstream tests
    21232123canvas/philip/tests/2d.drawImage.image.incomplete.omitted.html
    2124 canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6.html
    21252124canvas/philip/tests/2d.fillStyle.parse.rgb-eof.html
    21262125canvas/philip/tests/2d.fillStyle.parse.rgba-eof.html

  • trunk/Source/WebCore/ChangeLog

    r126191 r126192  
     12012-08-21  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
     2
     3        canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6.html fails
     4        https://bugs.webkit.org/show_bug.cgi?id=50797
     5
     6        Reviewed by Andreas Kling.
     7
     8        Add a check in fast-path parseAlphaValue() to return early
     9        if the CSS <alphavalue> ended with an invalid digit.
     10
     11        Test: canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6.html
     12
     13        * css/CSSParser.cpp:
     14        (WebCore::parseAlphaValue):
     15
    1162012-08-21  Benjamin Poulain  <bpoulain@apple.com>
    217

  • trunk/Source/WebCore/css/CSSParser.cpp

    r126105 r126192  
    53365336        return false;
    53375337
    5338     if (string[length - 1] != terminator)
     5338    if (string[length - 1] != terminator || !isASCIIDigit(string[length - 2]))
    53395339        return false;
    53405340
Note: See TracChangeset for help on using the changeset viewer.