Changeset 126358 in webkit


Ignore:
Timestamp:
Aug 22, 2012 3:23:12 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Test cases under fast/filesystem/workers are flaky when using JSC
​https://bugs.webkit.org/show_bug.cgi?id=94747

Patch by Leo Yang <​leoyang@rim.com> on 2012-08-22
Reviewed by Yong Li.

These test cases sometimes can't complete because the worker object
created by startWorker() has been gc'ed before the worker thread complete.
We should reference the object to avoid it being gc'ed.

  • fast/filesystem/workers/async-operations.html:
  • fast/filesystem/workers/file-entry-to-uri-sync.html:
  • fast/filesystem/workers/file-from-file-entry-sync.html:
  • fast/filesystem/workers/file-from-file-entry.html:
  • fast/filesystem/workers/file-writer-empty-blob.html:
  • fast/filesystem/workers/file-writer-events.html:
  • fast/filesystem/workers/file-writer-gc-blob.html:
  • fast/filesystem/workers/file-writer-sync-truncate-extend.html:
  • fast/filesystem/workers/file-writer-sync-write-overlapped.html:
  • fast/filesystem/workers/file-writer-truncate-extend.html:
  • fast/filesystem/workers/file-writer-write-overlapped.html:
  • fast/filesystem/workers/simple-persistent-sync.html:
  • fast/filesystem/workers/simple-persistent.html:
  • fast/filesystem/workers/simple-temporary-sync.html:
  • fast/filesystem/workers/simple-temporary.html:
  • fast/filesystem/workers/sync-operations.html:
Location:
trunk/LayoutTests
Files:
17 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r126350 r126358  
     12012-08-22  Leo Yang  <leoyang@rim.com>
     2
     3        Test cases under fast/filesystem/workers are flaky when using JSC
     4        https://bugs.webkit.org/show_bug.cgi?id=94747
     5
     6        Reviewed by Yong Li.
     7
     8        These test cases sometimes can't complete because the worker object
     9        created by startWorker() has been gc'ed before the worker thread complete.
     10        We should reference the object to avoid it being gc'ed.
     11
     12        * fast/filesystem/workers/async-operations.html:
     13        * fast/filesystem/workers/file-entry-to-uri-sync.html:
     14        * fast/filesystem/workers/file-from-file-entry-sync.html:
     15        * fast/filesystem/workers/file-from-file-entry.html:
     16        * fast/filesystem/workers/file-writer-empty-blob.html:
     17        * fast/filesystem/workers/file-writer-events.html:
     18        * fast/filesystem/workers/file-writer-gc-blob.html:
     19        * fast/filesystem/workers/file-writer-sync-truncate-extend.html:
     20        * fast/filesystem/workers/file-writer-sync-write-overlapped.html:
     21        * fast/filesystem/workers/file-writer-truncate-extend.html:
     22        * fast/filesystem/workers/file-writer-write-overlapped.html:
     23        * fast/filesystem/workers/simple-persistent-sync.html:
     24        * fast/filesystem/workers/simple-persistent.html:
     25        * fast/filesystem/workers/simple-temporary-sync.html:
     26        * fast/filesystem/workers/simple-temporary.html:
     27        * fast/filesystem/workers/sync-operations.html:
     28
    1292012-08-22  Anna Cavender  <annacc@chromium.org>
    230

  • trunk/LayoutTests/fast/filesystem/workers/async-operations.html

    r106898 r126358  
    55<body>
    66<script>
    7 startWorker('../resources/async-operations.js');
     7worker = startWorker('../resources/async-operations.js');
    88</script>
    99<script src="../../js/resources/js-test-post.js"></script>

  • trunk/LayoutTests/fast/filesystem/workers/file-entry-to-uri-sync.html

    r106898 r126358  
    55<body>
    66<script>
    7 startWorker('../resources/file-entry-to-uri-sync.js');
     7worker = startWorker('../resources/file-entry-to-uri-sync.js');
    88</script>
    99<script src="../../js/resources/js-test-post.js"></script>

  • trunk/LayoutTests/fast/filesystem/workers/file-from-file-entry-sync.html

    r106898 r126358  
    55<body>
    66<script>
    7 startWorker('../resources/file-from-file-entry-sync.js');
     7worker = startWorker('../resources/file-from-file-entry-sync.js');
    88</script>
    99<script src="../../js/resources/js-test-post.js"></script>

  • trunk/LayoutTests/fast/filesystem/workers/file-from-file-entry.html

    r106898 r126358  
    55<body>
    66<script>
    7 startWorker('../resources/file-from-file-entry.js');
     7worker = startWorker('../resources/file-from-file-entry.js');
    88</script>
    99<script src="../../js/resources/js-test-post.js"></script>

  • trunk/LayoutTests/fast/filesystem/workers/file-writer-empty-blob.html

    r125643 r126358  
    99<div id="console"></div>
    1010<script>
    11 startWorker("../resources/file-writer-empty-blob.js");
     11worker = startWorker("../resources/file-writer-empty-blob.js");
    1212</script>
    1313<script src="../../js/resources/js-test-post.js"></script>

  • trunk/LayoutTests/fast/filesystem/workers/file-writer-events.html

    r106898 r126358  
    99    <div id="console"></div>
    1010    <script>
    11         startWorker("../resources/file-writer-events.js");
     11        worker = startWorker("../resources/file-writer-events.js");
    1212    </script>
    1313    <script src="../../js/resources/js-test-post.js"></script>

  • trunk/LayoutTests/fast/filesystem/workers/file-writer-gc-blob.html

    r106898 r126358  
    99    <div id="console"></div>
    1010    <script>
    11         startWorker("../resources/file-writer-gc-blob.js");
     11        worker = startWorker("../resources/file-writer-gc-blob.js");
    1212    </script>
    1313    <script src="../../js/resources/js-test-post.js"></script>

  • trunk/LayoutTests/fast/filesystem/workers/file-writer-sync-truncate-extend.html

    r106898 r126358  
    99    <div id="console"></div>
    1010    <script>
    11         startWorker("../resources/file-writer-sync-truncate-extend.js");
     11        worker = startWorker("../resources/file-writer-sync-truncate-extend.js");
    1212    </script>
    1313    <script src="../../js/resources/js-test-post.js"></script>

  • trunk/LayoutTests/fast/filesystem/workers/file-writer-sync-write-overlapped.html

    r106898 r126358  
    99    <div id="console"></div>
    1010    <script>
    11         startWorker("../resources/file-writer-sync-write-overlapped.js");
     11        worker = startWorker("../resources/file-writer-sync-write-overlapped.js");
    1212    </script>
    1313    <script src="../../js/resources/js-test-post.js"></script>

  • trunk/LayoutTests/fast/filesystem/workers/file-writer-truncate-extend.html

    r106898 r126358  
    99    <div id="console"></div>
    1010    <script>
    11         startWorker("../resources/file-writer-truncate-extend.js");
     11        worker = startWorker("../resources/file-writer-truncate-extend.js");
    1212    </script>
    1313    <script src="../../js/resources/js-test-post.js"></script>

  • trunk/LayoutTests/fast/filesystem/workers/file-writer-write-overlapped.html

    r106898 r126358  
    99    <div id="console"></div>
    1010    <script>
    11         startWorker("../resources/file-writer-write-overlapped.js");
     11        worker = startWorker("../resources/file-writer-write-overlapped.js");
    1212    </script>
    1313    <script src="../../js/resources/js-test-post.js"></script>

  • trunk/LayoutTests/fast/filesystem/workers/simple-persistent-sync.html

    r106898 r126358  
    55<body>
    66<script>
    7 startWorker('../resources/simple-persistent-sync.js');
     7worker = startWorker('../resources/simple-persistent-sync.js');
    88</script>
    99<script src="../../js/resources/js-test-post.js"></script>

  • trunk/LayoutTests/fast/filesystem/workers/simple-persistent.html

    r106898 r126358  
    55<body>
    66<script>
    7 startWorker('../resources/simple-persistent.js');
     7worker = startWorker('../resources/simple-persistent.js');
    88</script>
    99<script src="../../js/resources/js-test-post.js"></script>

  • trunk/LayoutTests/fast/filesystem/workers/simple-temporary-sync.html

    r106898 r126358  
    55<body>
    66<script>
    7 startWorker('../resources/simple-temporary-sync.js');
     7worker = startWorker('../resources/simple-temporary-sync.js');
    88</script>
    99<script src="../../js/resources/js-test-post.js"></script>

  • trunk/LayoutTests/fast/filesystem/workers/simple-temporary.html

    r106898 r126358  
    55<body>
    66<script>
    7 startWorker('../resources/simple-temporary.js');
     7worker = startWorker('../resources/simple-temporary.js');
    88</script>
    99<script src="../../js/resources/js-test-post.js"></script>

  • trunk/LayoutTests/fast/filesystem/workers/sync-operations.html

    r106898 r126358  
    55<body>
    66<script>
    7 startWorker('../resources/sync-operations.js');
     7worker = startWorker('../resources/sync-operations.js');
    88</script>
    99<script src="../../js/resources/js-test-post.js"></script>
Note: See TracChangeset for help on using the changeset viewer.