Changeset 126384 in webkit

Timestamp:

Aug 22, 2012 7:33:37 PM (12 years ago)

Author:

mrowe@apple.com

Message:

Fix some tests on safari-536.26-branch.
​https://bugs.webkit.org/show_bug.cgi?id=94759

Patch by Mark Lam <​mark.lam@apple.com> on 2012-08-22
Reviewed by Mark Rowe.

• animations/animation-shorthand-name-order.html:
• compositing/repaint/newly-composited-on-scroll.html:
• editing/execCommand/crash-extend-selection-forward.html:
• fast/events/drag-display-none-element.html:
• fast/forms/autocomplete-off-with-default-value-does-not-clear.html:
• fast/forms/hidden/change-type-to-hidden-after-updating-value.html:
• fast/table/auto-table-layout-colgroup-removal-crash.html:
• fast/text/title-crash-expected.txt: Added.
• http/tests/security/video-poster-cross-origin-crash.html:
• platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt:
• plugins/npruntime/overrides-all-properties.html:

Location:

branches/safari-536.26-branch/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• animations/animation-shorthand-name-order.html (modified) (2 diffs)
• compositing/repaint/newly-composited-on-scroll.html (modified) (1 diff)
• editing/execCommand/crash-extend-selection-forward.html (modified) (2 diffs)
• fast/events/drag-display-none-element.html (modified) (1 diff)
• fast/forms/autocomplete-off-with-default-value-does-not-clear.html (modified) (2 diffs)
• fast/forms/hidden/change-type-to-hidden-after-updating-value.html (modified) (1 diff)
• fast/table/auto-table-layout-colgroup-removal-crash.html (modified) (1 diff)
• fast/text/title-crash-expected.txt (added)
• http/tests/security/video-poster-cross-origin-crash.html (modified) (2 diffs)
• platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt (modified) (1 diff)
• plugins/npruntime/overrides-all-properties.html (modified) (2 diffs)

branches/safari-536.26-branch/LayoutTests/ChangeLog

@@ +1 @@
+2012-08-22  Mark Lam  <mark.lam@apple.com>
+
+        Fix some tests on safari-536.26-branch.
+        https://bugs.webkit.org/show_bug.cgi?id=94759
+
+        Reviewed by Mark Rowe.
+
+        * animations/animation-shorthand-name-order.html:
+        * compositing/repaint/newly-composited-on-scroll.html:
+        * editing/execCommand/crash-extend-selection-forward.html:
+        * fast/events/drag-display-none-element.html:
+        * fast/forms/autocomplete-off-with-default-value-does-not-clear.html:
+        * fast/forms/hidden/change-type-to-hidden-after-updating-value.html:
+        * fast/table/auto-table-layout-colgroup-removal-crash.html:
+        * fast/text/title-crash-expected.txt: Added.
+        * http/tests/security/video-poster-cross-origin-crash.html:
+        * platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt:
+        * plugins/npruntime/overrides-all-properties.html:
+
 2012-08-20  Mark Rowe  <mrowe@apple.com>
 

branches/safari-536.26-branch/LayoutTests/animations/animation-shorthand-name-order.html

@@ -122 +122 @@
                 runIndividualTest(numTestsComplete);
             else {
-                if (window.testRunner)
-                    testRunner.notifyDone();
+                if (window.layoutTestController)
+                    layoutTestController.notifyDone();
             }
         }, 0);
@@ -129 +129 @@
 }
 
-if (window.testRunner) {
-    testRunner.dumpAsText();
-    testRunner.waitUntilDone();
+if (window.layoutTestController) {
+    layoutTestController.dumpAsText();
+    layoutTestController.waitUntilDone();
 }
 

branches/safari-536.26-branch/LayoutTests/compositing/repaint/newly-composited-on-scroll.html

@@ -57 +57 @@
 
 <script>
-    if (window.testRunner) {
-        testRunner.dumpAsText(true);
-        testRunner.waitUntilDone();
+    if (window.layoutTestController) {
+        layoutTestController.dumpAsText(true);
+        layoutTestController.waitUntilDone();
     }
 
     function repaintTest() {
-        if (window.testRunner)
-            testRunner.display();
+        if (window.layoutTestController)
+            layoutTestController.display();
 
         document.getElementById('overflow').scrollTop = 30;
-        if (window.testRunner)
-            testRunner.display();
+        if (window.layoutTestController)
+            layoutTestController.display();
 
         window.setTimeout(function() {
             document.getElementById('overflow').scrollTop = 50;
-            testRunner.notifyDone();
+            layoutTestController.notifyDone();
         }, 0);
     }

branches/safari-536.26-branch/LayoutTests/editing/execCommand/crash-extend-selection-forward.html

@@ -4 +4 @@
 <script src=../editing.js></script>
 <script>
-if (window.testRunner) {
-    testRunner.dumpAsText();
-    testRunner.waitUntilDone();
+if (window.layoutTestController) {
+    layoutTestController.dumpAsText();
+    layoutTestController.waitUntilDone();
 }
 
@@ -16 +16 @@
 
     test1.innerHTML = "PASS. WebKit didn't crash.";
-    if (window.testRunner)
-        testRunner.notifyDone();
+    if (window.layoutTestController)
+        layoutTestController.notifyDone();
 }
 </script>

branches/safari-536.26-branch/LayoutTests/fast/events/drag-display-none-element.html

@@ -13 +13 @@
     var dragme = document.getElementById('dragme');
     dragme.addEventListener('dragend', function () {
-        if (window.testRunner)
-            testRunner.notifyDone();
+        if (window.layoutTestController)
+            layoutTestController.notifyDone();
         document.getElementById('console').appendChild(document.createTextNode('PASS'));
     });
 
-    if (!window.testRunner)
+    if (!window.layoutTestController)
         return;
 
-    testRunner.waitUntilDone();
-    testRunner.dumpAsText();
+    layoutTestController.waitUntilDone();
+    layoutTestController.dumpAsText();
 
     eventSender.mouseMoveTo(dragme.offsetLeft + dragme.offsetWidth / 2, dragme.offsetTop + dragme.offsetHeight / 2);

branches/safari-536.26-branch/LayoutTests/fast/forms/autocomplete-off-with-default-value-does-not-clear.html

@@ -1 +1 @@
 <script>
 
-if (window.testRunner) {
-        testRunner.overridePreference("WebKitUsesPageCachePreferenceKey", 1);
-        testRunner.dumpAsText();
-        testRunner.waitUntilDone();
+if (window.layoutTestController) {
+        layoutTestController.overridePreference("WebKitUsesPageCachePreferenceKey", 1);
+        layoutTestController.dumpAsText();
+        layoutTestController.waitUntilDone();
 }
 
@@ -22 +22 @@
 {
         document.getElementById("logger").innerText = document.getElementById("testInput").value;
-        if (window.testRunner)
-                testRunner.notifyDone();
+        if (window.layoutTestController)
+                layoutTestController.notifyDone();
 }
 

branches/safari-536.26-branch/LayoutTests/fast/forms/hidden/change-type-to-hidden-after-updating-value.html

@@ -1 +1 @@
 <input type="text" id="input1">
 <script>
-if (window.testRunner)
-    testRunner.dumpAsText();
+if (window.layoutTestController)
+    layoutTestController.dumpAsText();
 document.getElementById('input1').value = 'value';
 document.getElementById('input1').type = 'hidden';

branches/safari-536.26-branch/LayoutTests/fast/table/auto-table-layout-colgroup-removal-crash.html

@@ -9 +9 @@
 </table>
 <script>
-    if (window.testRunner)
-        testRunner.dumpAsText();
+    if (window.layoutTestController)
+        layoutTestController.dumpAsText();
 
     document.body.offsetTop;

branches/safari-536.26-branch/LayoutTests/http/tests/security/video-poster-cross-origin-crash.html

@@ -1 +1 @@
 <sub id=tCF1></sub>>>><button hidden=false id=tCF7>><video crossorigin="" poster="http://localhost:8080/misc/resources/compass.jpg">><style>
 .c29:nth-child(1814762996n + 9999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999) { -webkit-locale: "zh_CN";</style><script>
-if (window.testRunner) {
-    testRunner.dumpAsText();
-    testRunner.waitUntilDone();
+if (window.layoutTestController) {
+    layoutTestController.dumpAsText();
+    layoutTestController.waitUntilDone();
 }
 docElement = document.body ? document.body : document.documentElement;
@@ -19 +19 @@
 window.scrollBy(-484, -400);
 try { tCF7.innerText = tCF44.textContent; } catch(e) {}
-if (window.testRunner)
-    testRunner.notifyDone();
+if (window.layoutTestController)
+    layoutTestController.notifyDone();
 }</script>

branches/safari-536.26-branch/LayoutTests/platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt

@@ -1 @@
-This test checks that markers are correct when auto correcting in the blockquote. If you type "n" and " ", there should be blue dots under information, but is off by one.
+This test checks that markers are correct when auto correcting in the blockquote. If you type "n" and " ", there should be blue dots under information, but is off by one. 
+Note, this test can fail due to user specific spell checking data. If the user has previously dismissed 'notational' as the correct spelling of 'notationl' several times, the spell checker will not provide 'information' as a suggestion anymore. To fix this, remove all files in ~/Library/Spelling.
 
 PASS internals.hasAutocorrectedMarker(document, 0, 1) is true

branches/safari-536.26-branch/LayoutTests/plugins/npruntime/overrides-all-properties.html

@@ -2 +2 @@
 
 <script>
-if (window.testRunner) {
-    testRunner.dumpAsText();
-    testRunner.waitUntilDone();
+if (window.layoutTestController) {
+    layoutTestController.dumpAsText();
+    layoutTestController.waitUntilDone();
 }
 
 function runTest() {
-    if (!window.testRunner) {
+    if (!window.layoutTestController) {
         log("This test can only be run under WebKit's testRunner environment");
         return;
     }
 
-    testRunner.evaluateScriptInIsolatedWorld(0, " \
+    layoutTestController.evaluateScriptInIsolatedWorld(0, " \
         function test(msg, expected) \
         { \
@@ -51 +51 @@
     ");
 
-    if (window.testRunner)
-        testRunner.notifyDone();
+    if (window.layoutTestController)
+        layoutTestController.notifyDone();
 }
 </script>