Changeset 126504 in webkit


Ignore:
Timestamp:
Aug 23, 2012 4:48:49 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[BlackBerry] Add a check to filter out cookies that tries to set the domain to a top level domain
https://bugs.webkit.org/show_bug.cgi?id=94722

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-08-23
Reviewed by Rob Buis.

Changing the topleveldomain method name for better readability.

Also renaming the TopLevelDomain.h in platform to DomainTools
because there exists other tests that should belong in the same file.

Only changing method names and include file names.

  • platform/blackberry/CookieParser.cpp:

(WebCore::CookieParser::parseOneCookie):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r126503 r126504  
     12012-08-23  Otto Derek Cheung  <otcheung@rim.com>
     2
     3
     4        [BlackBerry] Add a check to filter out cookies that tries to set the domain to a top level domain
     5        https://bugs.webkit.org/show_bug.cgi?id=94722
     6
     7        Reviewed by Rob Buis.
     8
     9        Changing the topleveldomain method name for better readability.
     10
     11        Also renaming the TopLevelDomain.h in platform to DomainTools
     12        because there exists other tests that should belong in the same file.
     13
     14        Only changing method names and include file names.
     15
     16        * platform/blackberry/CookieParser.cpp:
     17        (WebCore::CookieParser::parseOneCookie):
     18
    1192012-08-23  Shezan Baig  <shezbaig.wk@gmail.com>
    220
  • trunk/Source/WebCore/platform/blackberry/CookieParser.cpp

    r126336 r126504  
    3030#include "Logging.h"
    3131#include "ParsedCookie.h"
    32 #include <network/TopLevelDomain.h>
     32#include <network/DomainTools.h>
    3333#include <wtf/CurrentTime.h>
    3434#include <wtf/text/CString.h>
     
    275275                // Check whether the domain is a top level domain, if it is throw it out
    276276                // http://publicsuffix.org/list/
    277                 if (!BlackBerry::Platform::TopLevelDomain::isCookieWritableDomain(realDomain.utf8().data()))
     277                if (BlackBerry::Platform::isTopLevelDomain(realDomain.utf8().data()))
    278278                    LOG_AND_DELETE("Invalid cookie %s (domain): it did not pass the top level domain check", cookie.ascii().data());
    279279
Note: See TracChangeset for help on using the changeset viewer.