Changeset 126908 in webkit

Timestamp:

Aug 28, 2012 12:05:43 PM (12 years ago)

Author:

dmazzoni@google.com

Message:

AX: Should be able to tab to focus a link in a canvas subtree
​https://bugs.webkit.org/show_bug.cgi?id=94967

Reviewed by Chris Fleizach.

Source/WebCore:

Skips the hasNonEmptyBoundingBox check in isKeyboardFocusable
when in a canvas subtree.

Test: fast/events/tab-focus-link-in-canvas.html

• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::isKeyboardFocusable):

LayoutTests:

Adds a test to make sure you can tab to a link inside a canvas
subtree.

• fast/events/tab-focus-link-in-canvas-expected.txt: Added.
• fast/events/tab-focus-link-in-canvas.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/tab-focus-link-in-canvas-expected.txt (added)
• LayoutTests/fast/events/tab-focus-link-in-canvas.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLAnchorElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-08-28  Dominic Mazzoni  <dmazzoni@google.com>
+
+        AX: Should be able to tab to focus a link in a canvas subtree
+        https://bugs.webkit.org/show_bug.cgi?id=94967
+
+        Reviewed by Chris Fleizach.
+
+        Adds a test to make sure you can tab to a link inside a canvas
+        subtree.
+
+        * fast/events/tab-focus-link-in-canvas-expected.txt: Added.
+        * fast/events/tab-focus-link-in-canvas.html: Added.
+
 2012-08-28  Philip Rogers  <pdr@google.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-08-28  Dominic Mazzoni  <dmazzoni@google.com>
+
+        AX: Should be able to tab to focus a link in a canvas subtree
+        https://bugs.webkit.org/show_bug.cgi?id=94967
+
+        Reviewed by Chris Fleizach.
+
+        Skips the hasNonEmptyBoundingBox check in isKeyboardFocusable
+        when in a canvas subtree.
+
+        Test: fast/events/tab-focus-link-in-canvas.html
+
+        * html/HTMLAnchorElement.cpp:
+        (WebCore::HTMLAnchorElement::isKeyboardFocusable):
+
 2012-08-28  Koji Ishii  <kojiishi@gmail.com>
 

trunk/Source/WebCore/html/HTMLAnchorElement.cpp

@@ -114 +114 @@
     if (!document()->frame()->eventHandler()->tabsToLinks(event))
         return false;
+
+    if (isInCanvasSubtree())
+        return true;
 
     return hasNonEmptyBoundingBox();