Changeset 126960 in webkit

Timestamp:

Aug 28, 2012 10:54:51 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] Add support for localization to the Web Inspector
​https://bugs.webkit.org/show_bug.cgi?id=92961

Patch by Seokju Kwon <​seokju.kwon@samsung.com> on 2012-08-28
Reviewed by Gyuyoung Kim.

Implement InspectorFrontendClientEfl::localizedStringsURL()
to return the URL of the localizedStrings.js.

• WebCoreSupport/InspectorClientEfl.cpp:

(WebCore::InspectorClientEfl::openInspectorFrontend):
(WebCore::InspectorClientEfl::inspectorFilesPath):
(WebCore::InspectorFrontendClientEfl::localizedStringsURL):

Location:

trunk/Source/WebKit/efl

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/InspectorClientEfl.cpp (modified) (3 diffs)

trunk/Source/WebKit/efl/ChangeLog

@@ +1 @@
+2012-08-28  Seokju Kwon  <seokju.kwon@samsung.com>
+
+        [EFL] Add support for localization to the Web Inspector
+        https://bugs.webkit.org/show_bug.cgi?id=92961
+
+        Reviewed by Gyuyoung Kim.
+
+        Implement InspectorFrontendClientEfl::localizedStringsURL()
+        to return the URL of the localizedStrings.js.
+
+        * WebCoreSupport/InspectorClientEfl.cpp:
+        (WebCore::InspectorClientEfl::openInspectorFrontend):
+        (WebCore::InspectorClientEfl::inspectorFilesPath):
+        (WebCore::InspectorFrontendClientEfl::localizedStringsURL):
+
 2012-08-28  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp

@@ -94 +94 @@
     m_inspectorView = inspectorView;
 
-    String inspectorUri = inspectorFilesPath();
+    String inspectorUri = inspectorFilesPath() + "/inspector.html";
     ewk_view_uri_set(m_inspectorView, inspectorUri.utf8().data());
 
@@ -141 +141 @@
 String InspectorClientEfl::inspectorFilesPath()
 {
-    String inspectorFilesPath = makeString("file://", WEB_INSPECTOR_INSTALL_DIR, "/inspector.html");
-    if (access(inspectorFilesPath.utf8().data(), R_OK)) // On success, zero is returned
-        inspectorFilesPath = makeString("file://", WEB_INSPECTOR_DIR, "/inspector.html");
+    String inspectorFilesPath = "file://" + String(WEB_INSPECTOR_INSTALL_DIR);
+    if (access(inspectorFilesPath.utf8().data(), R_OK))
+        inspectorFilesPath = "file://" + String(WEB_INSPECTOR_DIR);
 
     return inspectorFilesPath;
@@ -169 +169 @@
 String InspectorFrontendClientEfl::localizedStringsURL()
 {
-    notImplemented();
-    return String();
+    return m_inspectorClient->inspectorFilesPath() + "/localizedStrings.js";
 }