Changeset 127415 in webkit


Ignore:
Timestamp:
Sep 3, 2012 2:56:55 AM (12 years ago)
Author:
caseq@chromium.org
Message:

Web Inspector: use linkifyResourceAsNode, not linkifyLocation when linkifying resources in Timeline
https://bugs.webkit.org/show_bug.cgi?id=95540

Reviewed by Pavel Feldman.

Linkify recource details using WebInspector.linkifyResourceAsNode(), so these bypass linkifier. Also
fix closure compiler warning.

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
(WebInspector.TimelinePresentationModel.Record.prototype._linkifyLocation):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r127414 r127415  
     12012-09-03  Andrey Kosyakov  <caseq@chromium.org>
     2
     3        Web Inspector: use linkifyResourceAsNode, not linkifyLocation when linkifying resources in Timeline
     4        https://bugs.webkit.org/show_bug.cgi?id=95540
     5
     6        Reviewed by Pavel Feldman.
     7
     8        Linkify recource details using WebInspector.linkifyResourceAsNode(), so these bypass linkifier. Also
     9        fix closure compiler warning.
     10
     11        * inspector/front-end/TimelinePresentationModel.js:
     12        (WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
     13        (WebInspector.TimelinePresentationModel.Record.prototype._linkifyLocation):
     14
    1152012-09-03  'Pavel Feldman'  <pfeldman@chromium.org>
    216
  • trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js

    r126765 r127415  
    752752            case recordTypes.ResourceReceivedData:
    753753            case recordTypes.ResourceFinish:
    754                 contentHelper._appendElementRow(WebInspector.UIString("Resource"), this._linkifyLocation(this.url));
     754                contentHelper._appendElementRow(WebInspector.UIString("Resource"), WebInspector.linkifyResourceAsNode(this.url));
    755755                if (previewElement)
    756756                    contentHelper._appendElementRow(WebInspector.UIString("Preview"), previewElement);
     
    871871    /**
    872872     * @param {string} url
    873      * @param {number=} lineNumber
     873     * @param {number} lineNumber
    874874     * @param {number=} columnNumber
    875875     */
     
    877877    {
    878878        // FIXME(62725): stack trace line/column numbers are one-based.
    879         lineNumber = lineNumber ? lineNumber - 1 : lineNumber;
    880879        columnNumber = columnNumber ? columnNumber - 1 : 0;
    881         return this._linkifier.linkifyLocation(url, lineNumber, columnNumber, "timeline-details");
     880        return this._linkifier.linkifyLocation(url, lineNumber - 1, columnNumber, "timeline-details");
    882881    },
    883882
Note: See TracChangeset for help on using the changeset viewer.