Changeset 127483 in webkit

Timestamp:

Sep 4, 2012 12:23:41 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] Crash in AccessibilityObject::accessibilityPlatformIncludesObject()
​https://bugs.webkit.org/show_bug.cgi?id=95740

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2012-09-04
Reviewed by Martin Robinson.

Source/WebCore:

Added sanity check to be sure we have a render object prior to seeing if
said object is an anonymous block.

Testing via unit test because a non-flaky layout test crasher could not
be found.

• accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Sanity check for render object added.

Source/WebKit/gtk:

Updated unit test.

• tests/testatk.c:

(testWebkitAtkComboBox): Added checks that the menu popup in a combo box
has 0 links and, more importantly, that checking doesn't result in a crash.

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp (modified) (1 diff)
• WebKit/gtk/ChangeLog (modified) (1 diff)
• WebKit/gtk/tests/testatk.c (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-09-04  Joanmarie Diggs  <jdiggs@igalia.com>
+
+        [GTK] Crash in AccessibilityObject::accessibilityPlatformIncludesObject()
+        https://bugs.webkit.org/show_bug.cgi?id=95740
+
+        Reviewed by Martin Robinson.
+
+        Added sanity check to be sure we have a render object prior to seeing if
+        said object is an anonymous block.
+
+        Testing via unit test because a non-flaky layout test crasher could not
+        be found.
+
+        * accessibility/gtk/AccessibilityObjectAtk.cpp:
+        (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
+        Sanity check for render object added.
+
 2012-09-04  Christophe Dumez  <christophe.dumez@intel.com>
 

trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp

@@ -105 +105 @@
     // have we encountered instances where the parent of an anonymous block also lacked
     // an aria role but the grandparent had one.
-    if (renderer()->isAnonymousBlock() && !parent->renderer()->isBody()
+    if (renderer() && renderer()->isAnonymousBlock() && !parent->renderer()->isBody()
         && parent->ariaRoleAttribute() == UnknownRole)
         return IgnoreObject;

trunk/Source/WebKit/gtk/ChangeLog

@@ +1 @@
+2012-09-04  Joanmarie Diggs  <jdiggs@igalia.com>
+
+        [GTK] Crash in AccessibilityObject::accessibilityPlatformIncludesObject()
+        https://bugs.webkit.org/show_bug.cgi?id=95740
+
+        Reviewed by Martin Robinson.
+
+        Updated unit test.
+
+        * tests/testatk.c:
+        (testWebkitAtkComboBox): Added checks that the menu popup in a combo box
+        has 0 links and, more importantly, that checking doesn't result in a crash.
+
 2012-09-01  Joanmarie Diggs  <jdiggs@igalia.com>
 

trunk/Source/WebKit/gtk/tests/testatk.c

@@ -562 +562 @@
     g_assert(selectedItem == item1);
     g_object_unref(selectedItem);
+
+    /* Check that the menu popup has 0 links and doesn't crash from checking. */
+    gint nLinks = atk_hypertext_get_n_links(ATK_HYPERTEXT(menuPopup));
+    g_assert_cmpint(nLinks, ==, 0);
 
     /* Check the implementations of the AtkAction interface. */