Changeset 127483 in webkit
- Timestamp:
- Sep 4, 2012 12:23:41 PM (12 years ago)
- Location:
- trunk/Source
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r127481 r127483 1 2012-09-04 Joanmarie Diggs <jdiggs@igalia.com> 2 3 [GTK] Crash in AccessibilityObject::accessibilityPlatformIncludesObject() 4 https://bugs.webkit.org/show_bug.cgi?id=95740 5 6 Reviewed by Martin Robinson. 7 8 Added sanity check to be sure we have a render object prior to seeing if 9 said object is an anonymous block. 10 11 Testing via unit test because a non-flaky layout test crasher could not 12 be found. 13 14 * accessibility/gtk/AccessibilityObjectAtk.cpp: 15 (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): 16 Sanity check for render object added. 17 1 18 2012-09-04 Christophe Dumez <christophe.dumez@intel.com> 2 19 -
trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp
r127370 r127483 105 105 // have we encountered instances where the parent of an anonymous block also lacked 106 106 // an aria role but the grandparent had one. 107 if (renderer() ->isAnonymousBlock() && !parent->renderer()->isBody()107 if (renderer() && renderer()->isAnonymousBlock() && !parent->renderer()->isBody() 108 108 && parent->ariaRoleAttribute() == UnknownRole) 109 109 return IgnoreObject; -
trunk/Source/WebKit/gtk/ChangeLog
r127367 r127483 1 2012-09-04 Joanmarie Diggs <jdiggs@igalia.com> 2 3 [GTK] Crash in AccessibilityObject::accessibilityPlatformIncludesObject() 4 https://bugs.webkit.org/show_bug.cgi?id=95740 5 6 Reviewed by Martin Robinson. 7 8 Updated unit test. 9 10 * tests/testatk.c: 11 (testWebkitAtkComboBox): Added checks that the menu popup in a combo box 12 has 0 links and, more importantly, that checking doesn't result in a crash. 13 1 14 2012-09-01 Joanmarie Diggs <jdiggs@igalia.com> 2 15 -
trunk/Source/WebKit/gtk/tests/testatk.c
r127367 r127483 562 562 g_assert(selectedItem == item1); 563 563 g_object_unref(selectedItem); 564 565 /* Check that the menu popup has 0 links and doesn't crash from checking. */ 566 gint nLinks = atk_hypertext_get_n_links(ATK_HYPERTEXT(menuPopup)); 567 g_assert_cmpint(nLinks, ==, 0); 564 568 565 569 /* Check the implementations of the AtkAction interface. */
Note: See TracChangeset
for help on using the changeset viewer.