Changeset 127489 in webkit

Timestamp:

Sep 4, 2012 1:03:17 PM (12 years ago)

Author:

staikos@webkit.org

Message:

[BlackBerry] pass isMainFrame() through to notifyDocumentOnLoad()
​https://bugs.webkit.org/show_bug.cgi?id=95766

Reviewed by Rob Buis.

Passing the frame status through will allow the client to make better
decisions about how to act on the onload.

• Api/WebPageClient.h:
• WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidHandleOnloadEvents):

Location:

trunk/Source/WebKit/blackberry

Files:

• Api/WebPageClient.h (modified) (1 diff)
• ChangeLog (modified) (1 diff)
• WebCoreSupport/FrameLoaderClientBlackBerry.cpp (modified) (1 diff)

trunk/Source/WebKit/blackberry/Api/WebPageClient.h

@@ -105 +105 @@
     virtual void notifyNoMouseMoveOrTouchMoveHandlers() = 0;
 
-    virtual void notifyDocumentOnLoad() = 0;
+    virtual void notifyDocumentOnLoad(bool) = 0;
 
     virtual void notifyWindowObjectCleared() = 0;

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2012-09-04  George Staikos  <staikos@webkit.org>
+
+        [BlackBerry] pass isMainFrame() through to notifyDocumentOnLoad()
+        https://bugs.webkit.org/show_bug.cgi?id=95766
+
+        Reviewed by Rob Buis.
+
+        Passing the frame status through will allow the client to make better
+        decisions about how to act on the onload.
+
+        * Api/WebPageClient.h:
+        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
+        (WebCore::FrameLoaderClientBlackBerry::dispatchDidHandleOnloadEvents):
+
 2012-09-04  Rob Buis  <rbuis@rim.com>
 

trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp

@@ -573 +573 @@
 void FrameLoaderClientBlackBerry::dispatchDidHandleOnloadEvents()
 {
-    m_webPagePrivate->m_client->notifyDocumentOnLoad();
+    m_webPagePrivate->m_client->notifyDocumentOnLoad(isMainFrame());
     if (m_webPagePrivate->m_dumpRenderTree)
         m_webPagePrivate->m_dumpRenderTree->didHandleOnloadEventsForFrame(m_frame);