Changeset 127538 in webkit

Timestamp:

Sep 4, 2012 6:31:38 PM (12 years ago)

Author:

tony@chromium.org

Message:

Use TrackedRendererListHashSet typedef for percentHeightDescendants()
​https://bugs.webkit.org/show_bug.cgi?id=95791

Reviewed by Ojan Vafai.

There were a couple callers that were using ListHashSet<RenderBox*> instead of the typedef.

No new tests, this is just a refactor.

• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

• rendering/RenderView.cpp:

(WebCore::RenderView::setFixedPositionedObjectsNeedLayout):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderTableSection.cpp (modified) (1 diff)
• rendering/RenderView.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-09-04  Tony Chang  <tony@chromium.org>
+
+        Use TrackedRendererListHashSet typedef for percentHeightDescendants()
+        https://bugs.webkit.org/show_bug.cgi?id=95791
+
+        Reviewed by Ojan Vafai.
+
+        There were a couple callers that were using ListHashSet<RenderBox*> instead of the typedef.
+
+        No new tests, this is just a refactor.
+
+        * rendering/RenderTableSection.cpp:
+        (WebCore::RenderTableSection::layoutRows):
+        * rendering/RenderView.cpp:
+        (WebCore::RenderView::setFixedPositionedObjectsNeedLayout):
+
 2012-09-04  Alec Flett  <alecflett@chromium.org>
 

trunk/Source/WebCore/rendering/RenderTableSection.cpp

@@ -580 +580 @@
             }
 
-            if (ListHashSet<RenderBox*>* percentHeightDescendants = cell->percentHeightDescendants()) {
-                ListHashSet<RenderBox*>::iterator end = percentHeightDescendants->end();
-                for (ListHashSet<RenderBox*>::iterator it = percentHeightDescendants->begin(); it != end; ++it) {
+            if (TrackedRendererListHashSet* percentHeightDescendants = cell->percentHeightDescendants()) {
+                TrackedRendererListHashSet::iterator end = percentHeightDescendants->end();
+                for (TrackedRendererListHashSet::iterator it = percentHeightDescendants->begin(); it != end; ++it) {
                     RenderBox* box = *it;
                     if (!box->isReplaced() && !box->scrollsOverflow() && !flexAllChildren)

trunk/Source/WebCore/rendering/RenderView.cpp

@@ -942 +942 @@
     ASSERT(m_frameView);
 
-    ListHashSet<RenderBox*>* positionedObjects = this->positionedObjects();
+    TrackedRendererListHashSet* positionedObjects = this->positionedObjects();
     if (!positionedObjects)
         return;
 
-    ListHashSet<RenderBox*>::const_iterator end = positionedObjects->end();
-    for (ListHashSet<RenderBox*>::const_iterator it = positionedObjects->begin(); it != end; ++it) {
+    TrackedRendererListHashSet::const_iterator end = positionedObjects->end();
+    for (TrackedRendererListHashSet::const_iterator it = positionedObjects->begin(); it != end; ++it) {
         RenderBox* currBox = *it;
         currBox->setNeedsLayout(true);