Changeset 127548 in webkit

Timestamp:

Sep 4, 2012 8:57:56 PM (12 years ago)

Author:

krit@webkit.org

Message:

-webkit-clip-path does not apply origin for polygon()
​https://bugs.webkit.org/show_bug.cgi?id=95656

Reviewed by Tim Horton.

Source/WebCore:

The polygon() shape function did not apply origin of bouding box on created path. The shape was
not moved to the correct position.

Tests: svg/clip-path/clip-path-shape-polygon-relative-expected.svg

svg/clip-path/clip-path-shape-polygon-relative.svg

• rendering/style/BasicShapes.cpp:

(WebCore::BasicShapePolygon::path): Apply origin of bounding box.

LayoutTests:

Check that the origin of the bounding box gets applied to the clip path.

• svg/clip-path/clip-path-shape-polygon-relative-expected.svg: Added.
• svg/clip-path/clip-path-shape-polygon-relative.svg: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/clip-path/clip-path-shape-polygon-relative-expected.svg (added)
• LayoutTests/svg/clip-path/clip-path-shape-polygon-relative.svg (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/style/BasicShapes.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-09-04  Dirk Schulze  <krit@webkit.org>
+
+        -webkit-clip-path does not apply origin for polygon()
+        https://bugs.webkit.org/show_bug.cgi?id=95656
+
+        Reviewed by Tim Horton.
+
+        Check that the origin of the bounding box gets applied to the clip path.
+
+        * svg/clip-path/clip-path-shape-polygon-relative-expected.svg: Added.
+        * svg/clip-path/clip-path-shape-polygon-relative.svg: Added.
+
 2012-09-04  Kenichi Ishibashi  <bashi@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-09-04  Dirk Schulze  <krit@webkit.org>
+
+        -webkit-clip-path does not apply origin for polygon()
+        https://bugs.webkit.org/show_bug.cgi?id=95656
+
+        Reviewed by Tim Horton.
+
+        The polygon() shape function did not apply origin of bouding box on created path. The shape was
+        not moved to the correct position.
+
+        Tests: svg/clip-path/clip-path-shape-polygon-relative-expected.svg
+               svg/clip-path/clip-path-shape-polygon-relative.svg
+
+        * rendering/style/BasicShapes.cpp:
+        (WebCore::BasicShapePolygon::path): Apply origin of bounding box.
+
 2012-09-04  Adam Barth  <abarth@chromium.org>
 

trunk/Source/WebCore/rendering/style/BasicShapes.cpp

@@ -83 +83 @@
         return;
 
-    path.moveTo(FloatPoint(floatValueForLength(m_values.at(0), boundingBox.width()),
-                           floatValueForLength(m_values.at(1), boundingBox.width())));
+    path.moveTo(FloatPoint(floatValueForLength(m_values.at(0), boundingBox.width()) + boundingBox.x(),
+                           floatValueForLength(m_values.at(1), boundingBox.width()) + boundingBox.y()));
     for (size_t i = 2; i < length; i = i + 2) {
-        path.addLineTo(FloatPoint(floatValueForLength(m_values.at(i), boundingBox.width()),
-                                  floatValueForLength(m_values.at(i + 1), boundingBox.width())));
+        path.addLineTo(FloatPoint(floatValueForLength(m_values.at(i), boundingBox.width()) + boundingBox.x(),
+                                  floatValueForLength(m_values.at(i + 1), boundingBox.width()) + boundingBox.y()));
     }
     path.closeSubpath();