Changeset 127702 in webkit

Timestamp:

Sep 6, 2012 12:21:03 AM (12 years ago)

Author:

abarth@webkit.org

Message:

Remove WTF::String::operator+=
​https://bugs.webkit.org/show_bug.cgi?id=95797

Patch by Adam Barth <​abarth@chromium.org> on 2012-09-06
Reviewed by Sam Weinig.

This patch encloses WTF::String::operator+= in an ifdef so that we can
gradually remove it from the various port-specific files. The ifdef
lets us whitelist use of operator+= in individual files during the
transition.

• wtf/Platform.h
• wtf/text/WTFString.h:

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/Platform.h (modified) (1 diff)
• wtf/text/WTFString.h (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2012-09-06  Adam Barth  <abarth@chromium.org>
+
+        Remove WTF::String::operator+=
+        https://bugs.webkit.org/show_bug.cgi?id=95797
+
+        Reviewed by Sam Weinig.
+
+        This patch encloses WTF::String::operator+= in an ifdef so that we can
+        gradually remove it from the various port-specific files. The ifdef
+        lets us whitelist use of operator+= in individual files during the
+        transition.
+
+        * wtf/Platform.h
+        * wtf/text/WTFString.h:
+
 2012-09-05  Gabor Rapcsanyi  <rgabor@webkit.org>
 

trunk/Source/WTF/wtf/Platform.h

@@ -1186 +1186 @@
 #endif
 
+#if PLATFORM(QT) || PLATFORM(GTK) || PLATFORM(WIN)
+#define WTF_DEPRECATED_STRING_OPERATORS
+#endif
+
 #if PLATFORM(QT)
 #include <qglobal.h>

trunk/Source/WTF/wtf/text/WTFString.h

@@ -467 +467 @@
 #endif
 
+#ifdef WTF_DEPRECATED_STRING_OPERATORS
 inline String& operator+=(String& a, const String& b) { a.append(b); return a; }
+#endif
 
 inline bool operator==(const String& a, const String& b) { return equal(a.impl(), b.impl()); }