Changeset 127966 in webkit


Ignore:
Timestamp:
Sep 8, 2012 3:48:09 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
​https://bugs.webkit.org/show_bug.cgi?id=95329

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-08
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add implementation for overriding the WebKitTabToLinksPreferenceKey
preference as well as the corresponding WKPreferences API that
is needed by WebKitTestRunner.

  • Shared/WebPreferencesStore.h:

(WebKit):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetTabToLinksEnabled):
(WKPreferencesGetTabToLinksEnabled):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::setTabToLinksEnabled):
(WebKit::WebPage::tabToLinksEnabled):

Tools:

Explicitely disable TabToLinks setting in WebKitTestRunner.
Tests override the "WebKitTabToLinksPreferenceKey" preference
to enable it.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

LayoutTests:

Unskip fast/events/tab-focus-link-in-canvas for WK2 now that WebKitTestRunner
supports overriding the "WebKitTabToLinksPreferenceKey" preference.

  • platform/efl-wk2/TestExpectations:
  • platform/wk2/Skipped:
Location:
trunk
Files:
11 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r127963 r127966  
     12012-09-08  Christophe Dumez  <christophe.dumez@intel.com>
     2
     3        [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
     4        https://bugs.webkit.org/show_bug.cgi?id=95329
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        Unskip fast/events/tab-focus-link-in-canvas for WK2 now that WebKitTestRunner
     9        supports overriding the "WebKitTabToLinksPreferenceKey" preference.
     10
     11        * platform/efl-wk2/TestExpectations:
     12        * platform/wk2/Skipped:
     13
    1142012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
    215

  • trunk/LayoutTests/platform/efl-wk2/TestExpectations

    r127909 r127966  
    166166BUGWKEFL : fast/events/touch/touch-target.html = TEXT
    167167
    168 // WebKit2 can't use TAB key to navigate on webpage links
    169 BUGWK95329 : fast/events/tab-focus-link-in-canvas.html = TEXT
    170 
    171168// WebKitTestRunner needs an implementation for testRunner.setViewModeMediaFeature
    172169BUGWKEFL : fast/media/media-query-list-02.html = TEXT

  • trunk/LayoutTests/platform/wk2/Skipped

    r127933 r127966  
    12781278fast/events/drag-display-none-element.html
    12791279
    1280 # [WK2] New fast/events/tab-focus-link-in-canvas.html fails
    1281 # https://bugs.webkit.org/show_bug.cgi?id=95329
    1282 fast/events/tab-focus-link-in-canvas.html
    1283 
    12841280# Skip tests in fast/text/shaping
    12851281fast/text/shaping

  • trunk/Source/WebKit2/ChangeLog

    r127958 r127966  
     12012-09-08  Christophe Dumez  <christophe.dumez@intel.com>
     2
     3        [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
     4        https://bugs.webkit.org/show_bug.cgi?id=95329
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        Add implementation for overriding the WebKitTabToLinksPreferenceKey
     9        preference as well as the corresponding WKPreferences API that
     10        is needed by WebKitTestRunner.
     11
     12        * Shared/WebPreferencesStore.h:
     13        (WebKit):
     14        * UIProcess/API/C/WKPreferences.cpp:
     15        (WKPreferencesSetTabToLinksEnabled):
     16        (WKPreferencesGetTabToLinksEnabled):
     17        * UIProcess/API/C/WKPreferencesPrivate.h:
     18        * WebProcess/InjectedBundle/InjectedBundle.cpp:
     19        (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
     20        * WebProcess/WebPage/WebPage.h:
     21        (WebKit::WebPage::setTabToLinksEnabled):
     22        (WebKit::WebPage::tabToLinksEnabled):
     23
    1242012-09-07  Benjamin Poulain  <bpoulain@apple.com>
    225

  • trunk/Source/WebKit2/Shared/WebPreferencesStore.h

    r127956 r127966  
    124124    macro(AsynchronousPluginInitializationEnabledForAllPlugins, asynchronousPluginInitializationEnabledForAllPlugins, Bool, bool, false) \
    125125    macro(ArtificialPluginInitializationDelayEnabled, artificialPluginInitializationDelayEnabled, Bool, bool, false) \
     126    macro(TabToLinksEnabled, tabToLinksEnabled, Bool, bool, false) \
    126127    macro(ScrollingPerformanceLoggingEnabled, scrollingPerformanceLoggingEnabled, Bool, bool, false) \
    127128    macro(StorageBlockingPolicy, storageBlockingPolicy, UInt32, uint32_t, 0) \

  • trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp

    r127956 r127966  
    875875}
    876876
     877void WKPreferencesSetTabToLinksEnabled(WKPreferencesRef preferencesRef, bool enabled)
     878{
     879    toImpl(preferencesRef)->setTabToLinksEnabled(enabled);
     880}
     881
     882bool WKPreferencesGetTabToLinksEnabled(WKPreferencesRef preferencesRef)
     883{
     884    return toImpl(preferencesRef)->tabToLinksEnabled();
     885}
     886
    877887void WKPreferencesSetScrollingPerformanceLoggingEnabled(WKPreferencesRef preferencesRef, bool enabled)
    878888{

  • trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h

    r125156 r127966  
    205205
    206206// Defaults to false
     207WK_EXPORT void WKPreferencesSetTabToLinksEnabled(WKPreferencesRef preferencesRef, bool enabled);
     208WK_EXPORT bool WKPreferencesGetTabToLinksEnabled(WKPreferencesRef preferencesRef);
     209
     210// Defaults to false
    207211WK_EXPORT void WKPreferencesSetScrollingPerformanceLoggingEnabled(WKPreferencesRef preferencesRef, bool enabled);
    208212WK_EXPORT bool WKPreferencesGetScrollingPerformanceLoggingEnabled(WKPreferencesRef preferencesRef);

  • trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp

    r127909 r127966  
    132132    const HashSet<Page*>& pages = PageGroup::pageGroup(pageGroup->identifier())->pages();
    133133
    134     // FIXME: Need an explicit way to set "WebKitTabToLinksPreferenceKey" directly in WebPage.
     134    if (preference == "WebKitTabToLinksPreferenceKey") {
     135       WebPreferencesStore::overrideBoolValueForKey(WebPreferencesKey::tabsToLinksKey(), enabled);
     136       for (HashSet<Page*>::iterator i = pages.begin(); i != pages.end(); ++i) {
     137            WebPage* webPage = static_cast<WebFrameLoaderClient*>((*i)->mainFrame()->loader()->client())->webFrame()->page();
     138            webPage->setTabToLinksEnabled(enabled);
     139        }
     140    }
    135141
    136142    if (preference == "WebKit2AsynchronousPluginInitializationEnabled") {

  • trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h

    r127862 r127966  
    582582    bool artificialPluginInitializationDelayEnabled() const { return m_artificialPluginInitializationDelayEnabled; }
    583583    void setArtificialPluginInitializationDelayEnabled(bool enabled) { m_artificialPluginInitializationDelayEnabled = enabled; }
     584    void setTabToLinksEnabled(bool enabled) { m_tabToLinks = enabled; }
     585    bool tabToLinksEnabled() const { return m_tabToLinks; }
    584586
    585587    bool scrollingPerformanceLoggingEnabled() const { return m_scrollingPerformanceLoggingEnabled; }

  • trunk/Tools/ChangeLog

    r127965 r127966  
     12012-09-08  Christophe Dumez  <christophe.dumez@intel.com>
     2
     3        [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
     4        https://bugs.webkit.org/show_bug.cgi?id=95329
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        Explicitely disable TabToLinks setting in WebKitTestRunner.
     9        Tests override the "WebKitTabToLinksPreferenceKey" preference
     10        to enable it.
     11
     12        * WebKitTestRunner/TestController.cpp:
     13        (WTR::TestController::resetStateToConsistentValues):
     14
    1152012-09-08  Kenichi Ishibashi  <bashi@chromium.org>
    216

  • trunk/Tools/WebKitTestRunner/TestController.cpp

    r127299 r127966  
    476476    WKPreferencesSetAsynchronousPluginInitializationEnabledForAllPlugins(preferences, false);
    477477    WKPreferencesSetArtificialPluginInitializationDelayEnabled(preferences, false);
     478    WKPreferencesSetTabToLinksEnabled(preferences, false);
    478479
    479480// [Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
Note: See TracChangeset for help on using the changeset viewer.