Changeset 128074 in webkit

Timestamp:

Sep 10, 2012 10:12:55 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK][a11y] editing/pasteboard/paste-blockquote-into-blockquote-4.html crashes
​https://bugs.webkit.org/show_bug.cgi?id=96199

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2012-09-10
Reviewed by Martin Robinson.

Added sanity check to correct erroneous assumption that there will
always be a child object.

No new tests as the bug crashes two existing Layout Tests which should
no longer crash as a result of this fix.

• accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/gtk/AccessibilityObjectAtk.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-09-10  Joanmarie Diggs  <jdiggs@igalia.com>
+
+        [GTK][a11y] editing/pasteboard/paste-blockquote-into-blockquote-4.html crashes
+        https://bugs.webkit.org/show_bug.cgi?id=96199
+
+        Reviewed by Martin Robinson.
+
+        Added sanity check to correct erroneous assumption that there will
+        always be a child object.
+
+        No new tests as the bug crashes two existing Layout Tests which should
+        no longer crash as a result of this fix.
+
+        * accessibility/gtk/AccessibilityObjectAtk.cpp:
+        (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
+
 2012-09-10  Mike West  <mkwst@chromium.org>
 

trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp

@@ -90 +90 @@
 
         child = child->firstChild();
-        if (child->isLink() || !child->firstAnonymousBlockChild())
+        if (child && (child->isLink() || !child->firstAnonymousBlockChild()))
             return IncludeObject;
     }