Changeset 128108 in webkit

Timestamp:

Sep 10, 2012 2:43:41 PM (12 years ago)

Author:

ryuan.choi@samsung.com

Message:

[WTR] Generated source files should include config.h
​https://bugs.webkit.org/show_bug.cgi?id=96254

Reviewed by Benjamin Poulain.

Current coding style has encouraged to include config.h at the first position,
But derived sources, generated by CodeGeneratorTestRunner.pm, don't follow
this rule.
Therefore, this patch added it.

• WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:

(_generateImplementationFile):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-09-10  Ryuan Choi  <ryuan.choi@samsung.com>
+
+        [WTR] Generated source files should include config.h
+        https://bugs.webkit.org/show_bug.cgi?id=96254
+
+        Reviewed by Benjamin Poulain.
+
+        Current coding style has encouraged to include config.h at the first position,
+        But derived sources, generated by CodeGeneratorTestRunner.pm, don't follow
+        this rule.
+        Therefore, this patch added it.
+
+        * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
+        (_generateImplementationFile):
+
 2012-09-10  Rick Byers  <rbyers@chromium.org>
 

trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm

@@ -329 +329 @@
 
     unshift(@contents, map { "#include \"$_\"\n" } sort keys(%contentsIncludes));
+    unshift(@contents, "#include \"config.h\"\n");
     unshift(@contents, @contentsPrefix);