Changeset 128128 in webkit

Timestamp:

Sep 10, 2012 4:26:34 PM (12 years ago)

Author:

Dimitri Glazkov

Message:

Reduce the number of treeScope queries when matching rules.
​https://bugs.webkit.org/show_bug.cgi?id=96315

Reviewed by Eric Seidel.

In the worst case, treeScope() requires a HashMap lookup, which could be slow. Since the value is always the same for the element,
we can just ask for it once.

No new tests, no change in behavior.

• css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList): Moved the call to treeScope out of the loop.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/StyleResolver.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-09-10  Dimitri Glazkov  <dglazkov@chromium.org>
+
+        Reduce the number of treeScope queries when matching rules.
+        https://bugs.webkit.org/show_bug.cgi?id=96315
+
+        Reviewed by Eric Seidel.
+
+        In the worst case, treeScope() requires a HashMap lookup, which could be slow. Since the value is always the same for the element,
+        we can just ask for it once.
+
+        No new tests, no change in behavior.
+
+        * css/StyleResolver.cpp:
+        (WebCore::StyleResolver::collectMatchingRulesForList): Moved the call to treeScope out of the loop.
+
 2012-09-10  Adam Barth  <abarth@chromium.org>
 

trunk/Source/WebCore/css/StyleResolver.cpp

@@ -1072 +1072 @@
     if (!rules)
         return;
+
+    TreeScope* treeScope = m_element->treeScope();
+
     // In some cases we may end up looking up style for random elements in the middle of a recursive tree resolve.
     // Ancestor identifier filter won't be up-to-date in that case and we can't use the fast path.
@@ -1094 +1097 @@
             // c) the rules comes from a scoped style sheet within the same tree scope
             // d) the rule contains shadow-ID pseudo elements
-            TreeScope* treeScope = m_element->treeScope();
             if (!MatchingUARulesScope::isMatchingUARules()
                 && !treeScope->applyAuthorStyles()