Changeset 128163 in webkit

Timestamp:

Sep 11, 2012 3:06:58 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[WK2][EFL] Fix compile warnings when enable tiled backing store
​https://bugs.webkit.org/show_bug.cgi?id=95342

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-09-11
Reviewed by Gyuyoung Kim.

Fixed compile time warning messages when enable tiled backing store.

• UIProcess/API/efl/ewk_view.cpp:

(ewk_view_accelerated_compositing_mode_enter): Fixed invalid use of 'EINA_SAFETY_ON_NULL_RETURN_VAL' since it used '!' ahead of evasGl value so it is always null.

• WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setChildren): Replaced 'int' i with 'unsigned' because its comparing value is 'size_t'.

• WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::renderNextFrame): Replaced 'int' i with 'unsigned' because its comparing value is 'size_t'.
(WebKit::LayerTreeCoordinator::beginContentUpdate): Replaced 'int' i with 'unsigned' because its comparing value is 'size_t'.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/efl/ewk_view.cpp (modified) (1 diff)
• WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp (modified) (1 diff)
• WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2012-09-11  Kangil Han  <kangil.han@samsung.com>
+
+        [WK2][EFL] Fix compile warnings when enable tiled backing store
+        https://bugs.webkit.org/show_bug.cgi?id=95342
+
+        Reviewed by Gyuyoung Kim.
+
+        Fixed compile time warning messages when enable tiled backing store.
+
+        * UIProcess/API/efl/ewk_view.cpp:
+        (ewk_view_accelerated_compositing_mode_enter): Fixed invalid use of 'EINA_SAFETY_ON_NULL_RETURN_VAL' since it used '!' ahead of evasGl value so it is always null.
+        * WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
+        (WebCore::CoordinatedGraphicsLayer::setChildren): Replaced 'int' i with 'unsigned' because its comparing value is 'size_t'.
+        * WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
+        (WebKit::LayerTreeCoordinator::renderNextFrame): Replaced 'int' i with 'unsigned' because its comparing value is 'size_t'.
+        (WebKit::LayerTreeCoordinator::beginContentUpdate): Replaced 'int' i with 'unsigned' because its comparing value is 'size_t'.
+
 2012-09-11  Byungwoo Lee  <bw80.lee@samsung.com>
 

trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp

@@ -499 +499 @@
     EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, false);
 
-    EINA_SAFETY_ON_NULL_RETURN_VAL(!priv->evasGl, false);
+    EINA_SAFETY_ON_NULL_RETURN_VAL(priv->evasGl, false);
 
     Evas* evas = evas_object_evas_get(ewkView);

trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp

@@ -152 +152 @@
     if (!ok)
         return false;
-    for (int i = 0; i < children.size(); ++i) {
+    for (unsigned i = 0; i < children.size(); ++i) {
         CoordinatedGraphicsLayer* child = toCoordinatedGraphicsLayer(children[i]);
         child->setCoordinatedGraphicsLayerClient(m_CoordinatedGraphicsLayerClient);

trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp

@@ -601 +601 @@
     m_waitingForUIProcess = false;
     scheduleLayerFlush();
-    for (int i = 0; i < m_updateAtlases.size(); ++i)
+    for (unsigned i = 0; i < m_updateAtlases.size(); ++i)
         m_updateAtlases[i]->didSwapBuffers();
 }
@@ -623 +623 @@
 {
     OwnPtr<WebCore::GraphicsContext> graphicsContext;
-    for (int i = 0; i < m_updateAtlases.size(); ++i) {
+    for (unsigned i = 0; i < m_updateAtlases.size(); ++i) {
         UpdateAtlas* atlas = m_updateAtlases[i].get();
         if (atlas->flags() == flags) {