Changeset 128230 in webkit

Timestamp:

Sep 11, 2012 3:25:29 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[BlackBerry] add a way to overscroll non-overflown content
​https://bugs.webkit.org/show_bug.cgi?id=96331
PR #195305

Patch by Antonio Gomes <​agomes@rim.com> on 2012-09-11
Reviewed by Yong Li.

Check -webkit-overflow-scrolling value for '-blackberry-touch' instead
of checking a custom HTML5 attribute.

No behavioural change. Mostly a rework of r128142.

• Api/InRegionScroller.cpp:

(BlackBerry::WebKit::canScrollRenderBox):

Location:

trunk/Source/WebKit/blackberry

Files:

• Api/InRegionScroller.cpp (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Source/WebKit/blackberry/Api/InRegionScroller.cpp

@@ -368 +368 @@
     // We use this to make non-overflown contents layers to actually
     // be overscrollable.
-    if (box->layer() && box->layer()->usesCompositedScrolling()
-        && box->layer()->enclosingElement() && box->layer()->enclosingElement()->isElementNode()) {
-        DEFINE_STATIC_LOCAL(QualifiedName, forceOverscrollAttr, (nullAtom, "data-blackberry-force-overscroll", nullAtom));
-
-        Element* element = static_cast<Element*>(box->layer()->enclosingElement());
-        if (element->fastHasAttribute(forceOverscrollAttr))
+    if (box->layer() && box->layer()->usesCompositedScrolling()) {
+        if (box->style()->overflowScrolling() == OSBlackberryTouch)
             return true;
     }

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2012-09-11  Antonio Gomes  <agomes@rim.com>
+
+        [BlackBerry] add a way to overscroll non-overflown content
+        https://bugs.webkit.org/show_bug.cgi?id=96331
+        PR #195305
+
+        Reviewed by Yong Li.
+
+        Check -webkit-overflow-scrolling value for '-blackberry-touch' instead
+        of checking a custom HTML5 attribute.
+
+        No behavioural change. Mostly a rework of r128142.
+
+        * Api/InRegionScroller.cpp:
+        (BlackBerry::WebKit::canScrollRenderBox):
+
 2012-09-11  Rob Buis  <rbuis@rim.com>