Changeset 128257 in webkit

Timestamp:

Sep 11, 2012 7:24:57 PM (12 years ago)

Author:

keishi@webkit.org

Message:

Create Localizer factory method for LocaleICU
​https://bugs.webkit.org/show_bug.cgi?id=96363

Reviewed by Kent Tamura.

Source/WebCore:

Preparing to use Localizer instead of LocaleMac/Win/ICU

No new tests. Covered in unit test tests/LocalizedNumberICUTest.cpp

• platform/text/LocaleICU.cpp:

(WebCore::Localizer::create):
(WebCore):

Source/WebKit/chromium:

• tests/LocalizedNumberICUTest.cpp:

(testNumberIsReversible):
(testDecimalSeparator):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/text/LocaleICU.cpp (modified) (1 diff)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/tests/LocalizedNumberICUTest.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-09-11  Keishi Hattori  <keishi@webkit.org>
+
+        Create Localizer factory method for LocaleICU
+        https://bugs.webkit.org/show_bug.cgi?id=96363
+
+        Reviewed by Kent Tamura.
+
+        Preparing to use Localizer instead of LocaleMac/Win/ICU
+
+        No new tests. Covered in unit test tests/LocalizedNumberICUTest.cpp
+
+        * platform/text/LocaleICU.cpp:
+        (WebCore::Localizer::create):
+        (WebCore):
+
 2012-09-11  Michael Saboff  <msaboff@apple.com>
 

trunk/Source/WebCore/platform/text/LocaleICU.cpp

@@ -42 +42 @@
 
 namespace WebCore {
+
+PassOwnPtr<Localizer> Localizer::create(const AtomicString& locale)
+{
+    return LocaleICU::create(locale.string().utf8().data());
+}
 
 LocaleICU::LocaleICU(const char* locale)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2012-09-11  Keishi Hattori  <keishi@webkit.org>
+
+        Create Localizer factory method for LocaleICU
+        https://bugs.webkit.org/show_bug.cgi?id=96363
+
+        Reviewed by Kent Tamura.
+
+        * tests/LocalizedNumberICUTest.cpp:
+        (testNumberIsReversible):
+        (testDecimalSeparator):
+
 2012-09-11  Christopher Cameron  <ccameron@chromium.org>
 

trunk/Source/WebKit/chromium/tests/LocalizedNumberICUTest.cpp

@@ -37 +37 @@
 using namespace WebCore;
 
-void testNumberIsReversible(const char* localeString, const char* original, const char* shouldHave = 0)
+void testNumberIsReversible(const AtomicString& locale, const char* original, const char* shouldHave = 0)
 {
-    OwnPtr<LocaleICU> locale = LocaleICU::create(localeString);
-    String localized = locale->convertToLocalizedNumber(original);
+    OwnPtr<Localizer> localizer = Localizer::create(locale);
+    String localized = localizer->convertToLocalizedNumber(original);
     if (shouldHave)
         EXPECT_TRUE(localized.contains(shouldHave));
-    String converted = locale->convertFromLocalizedNumber(localized);
+    String converted = localizer->convertFromLocalizedNumber(localized);
     EXPECT_EQ(original, converted);
 }
@@ -83 +83 @@
 #if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
 
-static String testDecimalSeparator(const char* localeString)
+static String testDecimalSeparator(const AtomicString& locale)
 {
-    OwnPtr<LocaleICU> locale = LocaleICU::create(localeString);
-    return locale->localizedDecimalSeparator();
+    OwnPtr<Localizer> localizer = Localizer::create(locale);
+    return localizer->localizedDecimalSeparator();
 }