Changeset 128327 in webkit

Timestamp:

Sep 12, 2012 9:41:58 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] [WK2] Memory leaks in TestControllerEfl
​https://bugs.webkit.org/show_bug.cgi?id=96525

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-09-12
Reviewed by Kenneth Rohde Christiansen.

Fix memory leaks in EFL's TestRunner code by adopting an allocation
of WKString created with WKStringCreateWithUTF8CString().

• WebKitTestRunner/efl/TestControllerEfl.cpp:

(WTR::TestController::initializeInjectedBundlePath):
(WTR::TestController::initializeTestPluginDirectory):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/efl/TestControllerEfl.cpp (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-09-12  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
+
+        [EFL] [WK2] Memory leaks in TestControllerEfl
+        https://bugs.webkit.org/show_bug.cgi?id=96525
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Fix memory leaks in EFL's TestRunner code by adopting an allocation
+        of WKString created with WKStringCreateWithUTF8CString().
+
+        * WebKitTestRunner/efl/TestControllerEfl.cpp:
+        (WTR::TestController::initializeInjectedBundlePath):
+        (WTR::TestController::initializeTestPluginDirectory):
+
 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
 

trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp

@@ -86 +86 @@
 {
     const char* bundlePath = getEnvironmentVariableOrExit("TEST_RUNNER_INJECTED_BUNDLE_FILENAME");
-    m_injectedBundlePath = WKStringCreateWithUTF8CString(bundlePath);
+    m_injectedBundlePath.adopt(WKStringCreateWithUTF8CString(bundlePath));
 }
 
@@ -92 +92 @@
 {
     const char* pluginPath = getEnvironmentVariableOrExit("TEST_RUNNER_PLUGIN_PATH");
-    m_testPluginDirectory = WKStringCreateWithUTF8CString(pluginPath);
+    m_testPluginDirectory.adopt(WKStringCreateWithUTF8CString(pluginPath));
 }