Changeset 128332 in webkit

Timestamp:

Sep 12, 2012 9:57:16 AM (12 years ago)

Author:

dmazzoni@google.com

Message:

Assert hit in is multiSelectable()
​https://bugs.webkit.org/show_bug.cgi?id=96530

Reviewed by Chris Fleizach.

Fix crash if element isn't a select element.

This bug slipped through in a refactoring change (bug 96323).
Covered by existing tests.

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isMultiSelectable):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/AccessibilityNodeObject.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-09-12  Dominic Mazzoni  <dmazzoni@google.com>
+
+        Assert hit in is multiSelectable()
+        https://bugs.webkit.org/show_bug.cgi?id=96530
+
+        Reviewed by Chris Fleizach.
+
+        Fix crash if element isn't a select element.
+
+        This bug slipped through in a refactoring change (bug 96323).
+        Covered by existing tests.
+
+        * accessibility/AccessibilityNodeObject.cpp:
+        (WebCore::AccessibilityNodeObject::isMultiSelectable):
+
 2012-09-11 MORITA Hajime  <morrita@google.com>
 

trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp

@@ -623 +623 @@
         return false;
     
-    return node() && toHTMLSelectElement(node())->multiple();
+    return node() && node()->hasTagName(selectTag) && toHTMLSelectElement(node())->multiple();
 }