Changeset 128347 in webkit


Ignore:
Timestamp:
Sep 12, 2012 12:21:41 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING
https://bugs.webkit.org/show_bug.cgi?id=96251

Patch by Sami Kyostila <skyostil@google.com> on 2012-09-12
Reviewed by Simon Fraser.

Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING to better describe
the feature it controls.

.:

  • Source/cmakeconfig.h.cmake:

Source/WebCore:

No tests because of no change in runtime behavior.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::usesCompositedScrolling):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

(StyleRareInheritedData):

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataEnableFeatures.in:

Source/WebKit/chromium:

  • features.gypi:

LayoutTests:

  • platform/chromium/TestExpectations:
Location:
trunk
Files:
19 edited

Legend:

Unmodified
Added
Removed
  • trunk/ChangeLog

    r128261 r128347  
     12012-09-12  Sami Kyostila  <skyostil@google.com>
     2
     3        Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING
     4        https://bugs.webkit.org/show_bug.cgi?id=96251
     5
     6        Reviewed by Simon Fraser.
     7
     8        Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING to better describe
     9        the feature it controls.
     10
     11        * Source/cmakeconfig.h.cmake:
     12
    1132012-09-11  Ryuan Choi  <ryuan.choi@samsung.com>
    214
  • trunk/LayoutTests/ChangeLog

    r128346 r128347  
     12012-09-12  Sami Kyostila  <skyostil@google.com>
     2
     3        Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING
     4        https://bugs.webkit.org/show_bug.cgi?id=96251
     5
     6        Reviewed by Simon Fraser.
     7
     8        Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING to better describe
     9        the feature it controls.
     10
     11        * platform/chromium/TestExpectations:
     12
    1132012-09-12  Levi Weintraub  <leviw@chromium.org>
    214
  • trunk/LayoutTests/platform/chromium/TestExpectations

    r128346 r128347  
    34513451BUGWK94261 DEBUG : http/tests/inspector/indexeddb/resources-panel.html = PASS CRASH TIMEOUT
    34523452
    3453 // ENABLE_OVERFLOW_SCROLLING is not currently enabled in Chromium.
     3453// ENABLE_ACCELERATED_OVERFLOW_SCROLLING is not currently enabled in Chromium.
    34543454BUGWK94353 : compositing/overflow/scrolling-content-clip-to-viewport.html = TEXT
    34553455BUGWK94353 : compositing/overflow/textarea-scroll-touch.html = TEXT
  • trunk/Source/WebCore/ChangeLog

    r128346 r128347  
     12012-09-12  Sami Kyostila  <skyostil@google.com>
     2
     3        Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING
     4        https://bugs.webkit.org/show_bug.cgi?id=96251
     5
     6        Reviewed by Simon Fraser.
     7
     8        Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING to better describe
     9        the feature it controls.
     10
     11        No tests because of no change in runtime behavior.
     12
     13        * css/CSSComputedStyleDeclaration.cpp:
     14        (WebCore):
     15        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
     16        * css/CSSParser.cpp:
     17        (WebCore::isValidKeywordPropertyAndValue):
     18        (WebCore::isKeywordPropertyID):
     19        (WebCore::CSSParser::parseValue):
     20        * css/CSSProperty.cpp:
     21        (WebCore::CSSProperty::isInheritedProperty):
     22        * css/CSSPropertyNames.in:
     23        * css/CSSValueKeywords.in:
     24        * css/StyleResolver.cpp:
     25        (WebCore::StyleResolver::collectMatchingRulesForList):
     26        * rendering/RenderLayer.cpp:
     27        (WebCore::RenderLayer::usesCompositedScrolling):
     28        * rendering/style/RenderStyle.h:
     29        * rendering/style/StyleRareInheritedData.cpp:
     30        (WebCore::StyleRareInheritedData::StyleRareInheritedData):
     31        (WebCore::StyleRareInheritedData::operator==):
     32        * rendering/style/StyleRareInheritedData.h:
     33        (StyleRareInheritedData):
     34
    1352012-09-12  Levi Weintraub  <leviw@chromium.org>
    236
  • trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp

    r127869 r128347  
    305305    CSSPropertyWebkitNbspMode,
    306306    CSSPropertyWebkitOrder,
    307 #if ENABLE(OVERFLOW_SCROLLING)
     307#if ENABLE(ACCELERATED_OVERFLOW_SCROLLING)
    308308    CSSPropertyWebkitOverflowScrolling,
    309309#endif
     
    22752275        case CSSPropertyWebkitMarginBeforeCollapse:
    22762276            return cssValuePool().createValue(style->marginBeforeCollapse());
    2277 #if ENABLE(OVERFLOW_SCROLLING)
     2277#if ENABLE(ACCELERATED_OVERFLOW_SCROLLING)
    22782278        case CSSPropertyWebkitOverflowScrolling:
    22792279            if (!style->useTouchOverflowScrolling())
  • trunk/Source/WebCore/css/CSSParser.cpp

    r127737 r128347  
    835835            return true;
    836836        break;
    837 #if ENABLE(OVERFLOW_SCROLLING)
     837#if ENABLE(ACCELERATED_OVERFLOW_SCROLLING)
    838838    case CSSPropertyWebkitOverflowScrolling:
    839839        if (valueID == CSSValueAuto || valueID == CSSValueTouch)
     
    10131013    case CSSPropertyWebkitMarqueeStyle:
    10141014    case CSSPropertyWebkitNbspMode:
    1015 #if ENABLE(OVERFLOW_SCROLLING)
     1015#if ENABLE(ACCELERATED_OVERFLOW_SCROLLING)
    10161016    case CSSPropertyWebkitOverflowScrolling:
    10171017#endif
     
    28732873    case CSSPropertyWebkitMarqueeStyle:
    28742874    case CSSPropertyWebkitNbspMode:
    2875 #if ENABLE(OVERFLOW_SCROLLING)
     2875#if ENABLE(ACCELERATED_OVERFLOW_SCROLLING)
    28762876    case CSSPropertyWebkitOverflowScrolling:
    28772877#endif
  • trunk/Source/WebCore/css/CSSProperty.cpp

    r127869 r128347  
    343343    case CSSPropertyWebkitLineSnap:
    344344    case CSSPropertyWebkitNbspMode:
    345 #if ENABLE(OVERFLOW_SCROLLING)
     345#if ENABLE(ACCELERATED_OVERFLOW_SCROLLING)
    346346    case CSSPropertyWebkitOverflowScrolling:
    347347#endif
  • trunk/Source/WebCore/css/CSSPropertyNames.in

    r127737 r128347  
    412412-webkit-widget-region
    413413#endif
    414 #if defined(ENABLE_OVERFLOW_SCROLLING) && ENABLE_OVERFLOW_SCROLLING
     414#if defined(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) && ENABLE_ACCELERATED_OVERFLOW_SCROLLING
    415415-webkit-overflow-scrolling
    416416#endif
  • trunk/Source/WebCore/css/CSSValueKeywords.in

    r127318 r128347  
    830830// auto
    831831
    832 #if defined(ENABLE_OVERFLOW_SCROLLING) && ENABLE_OVERFLOW_SCROLLING
     832#if defined(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) && ENABLE_ACCELERATED_OVERFLOW_SCROLLING
    833833// -webkit-overflow-scrolling
    834834// auto
  • trunk/Source/WebCore/css/StyleResolver.cpp

    r128329 r128347  
    22012201        || (style->position() == FixedPosition && e && e->document()->page() && e->document()->page()->settings()->fixedPositionCreatesStackingContext())
    22022202#endif
    2203 #if ENABLE(OVERFLOW_SCROLLING)
     2203#if ENABLE(ACCELERATED_OVERFLOW_SCROLLING)
    22042204        // Touch overflow scrolling creates a stacking context.
    22052205        || ((style->overflowX() != OHIDDEN || style->overflowY() != OHIDDEN) && style->useTouchOverflowScrolling())
     
    40484048    }
    40494049#endif
    4050 #if ENABLE(OVERFLOW_SCROLLING)
     4050#if ENABLE(ACCELERATED_OVERFLOW_SCROLLING)
    40514051    case CSSPropertyWebkitOverflowScrolling: {
    40524052        HANDLE_INHERIT_AND_INITIAL(useTouchOverflowScrolling, UseTouchOverflowScrolling);
  • trunk/Source/WebCore/rendering/RenderLayer.cpp

    r128346 r128347  
    15741574        return false;
    15751575
    1576 #if ENABLE(OVERFLOW_SCROLLING)
     1576#if ENABLE(ACCELERATED_OVERFLOW_SCROLLING)
    15771577    return renderer()->style()->useTouchOverflowScrolling();
    15781578#else
  • trunk/Source/WebCore/rendering/style/RenderStyle.h

    r127826 r128347  
    954954    Color tapHighlightColor() const { return rareInheritedData->tapHighlightColor; }
    955955#endif
    956 #if ENABLE(OVERFLOW_SCROLLING)
     956#if ENABLE(ACCELERATED_OVERFLOW_SCROLLING)
    957957    bool useTouchOverflowScrolling() const { return rareInheritedData->useTouchOverflowScrolling; }
    958958#endif
     
    14061406    void setTapHighlightColor(const Color& c) { SET_VAR(rareInheritedData, tapHighlightColor, c); }
    14071407#endif
    1408 #if ENABLE(OVERFLOW_SCROLLING)
     1408#if ENABLE(ACCELERATED_OVERFLOW_SCROLLING)
    14091409    void setUseTouchOverflowScrolling(bool v) { SET_VAR(rareInheritedData, useTouchOverflowScrolling, v); }
    14101410#endif
     
    17281728    static Color initialTapHighlightColor();
    17291729#endif
    1730 #if ENABLE(OVERFLOW_SCROLLING)
     1730#if ENABLE(ACCELERATED_OVERFLOW_SCROLLING)
    17311731    static bool initialUseTouchOverflowScrolling() { return false; }
    17321732#endif
  • trunk/Source/WebCore/rendering/style/StyleRareInheritedData.cpp

    r127869 r128347  
    8989    , m_lineSnap(RenderStyle::initialLineSnap())
    9090    , m_lineAlign(RenderStyle::initialLineAlign())
    91 #if ENABLE(OVERFLOW_SCROLLING)
     91#if ENABLE(ACCELERATED_OVERFLOW_SCROLLING)
    9292    , useTouchOverflowScrolling(RenderStyle::initialUseTouchOverflowScrolling())
    9393#endif
     
    151151    , m_lineSnap(o.m_lineSnap)
    152152    , m_lineAlign(o.m_lineAlign)
    153 #if ENABLE(OVERFLOW_SCROLLING)
     153#if ENABLE(ACCELERATED_OVERFLOW_SCROLLING)
    154154    , useTouchOverflowScrolling(o.useTouchOverflowScrolling)
    155155#endif
     
    216216        && nbspMode == o.nbspMode
    217217        && khtmlLineBreak == o.khtmlLineBreak
    218 #if ENABLE(OVERFLOW_SCROLLING)
     218#if ENABLE(ACCELERATED_OVERFLOW_SCROLLING)
    219219        && useTouchOverflowScrolling == o.useTouchOverflowScrolling
    220220#endif
  • trunk/Source/WebCore/rendering/style/StyleRareInheritedData.h

    r127737 r128347  
    105105    unsigned m_lineSnap : 2; // LineSnap
    106106    unsigned m_lineAlign : 1; // LineAlign
    107 #if ENABLE(OVERFLOW_SCROLLING)
     107#if ENABLE(ACCELERATED_OVERFLOW_SCROLLING)
    108108    unsigned useTouchOverflowScrolling: 1;
    109109#endif
  • trunk/Source/WebKit/blackberry/ChangeLog

    r128230 r128347  
     12012-09-12  Sami Kyostila  <skyostil@google.com>
     2
     3        Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING
     4        https://bugs.webkit.org/show_bug.cgi?id=96251
     5
     6        Reviewed by Simon Fraser.
     7
     8        Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING to better describe
     9        the feature it controls.
     10
     11        * WebCoreSupport/AboutDataEnableFeatures.in:
     12
    1132012-09-11  Antonio Gomes  <agomes@rim.com>
    214
  • trunk/Source/WebKit/blackberry/WebCoreSupport/AboutDataEnableFeatures.in

    r126735 r128347  
    223D_RENDERING
    33ACCELERATED_2D_CANVAS
     4ACCELERATED_OVERFLOW_SCROLLING
    45ALL_VARIABLES_CAPTURED
    56ASSEMBLER
     
    135136ORIENTATION_EVENTS
    136137OSR_ENTRY
    137 OVERFLOW_SCROLLING
    138138PAGE_POPUP
    139139PAGE_VISIBILITY_API
  • trunk/Source/WebKit/chromium/ChangeLog

    r128344 r128347  
     12012-09-12  Sami Kyostila  <skyostil@google.com>
     2
     3        Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING
     4        https://bugs.webkit.org/show_bug.cgi?id=96251
     5
     6        Reviewed by Simon Fraser.
     7
     8        Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING to better describe
     9        the feature it controls.
     10
     11        * features.gypi:
     12
    1132012-09-12  Christopher Cameron  <ccameron@chromium.org>
    214
  • trunk/Source/WebKit/chromium/features.gypi

    r127354 r128347  
    148148      ['OS=="android"', {
    149149        'feature_defines': [
     150          'ENABLE_ACCELERATED_OVERFLOW_SCROLLING=1',
    150151          'ENABLE_CALENDAR_PICKER=0',
    151152          'ENABLE_DATALIST_ELEMENT=0',
     
    158159          'ENABLE_NOTIFICATIONS=0',
    159160          'ENABLE_ORIENTATION_EVENTS=1',
    160           'ENABLE_OVERFLOW_SCROLLING=1',
    161161          'ENABLE_PAGE_POPUP=0',
    162162          'ENABLE_PRINTING=0',
     
    170170      }, { # OS!="android"
    171171        'feature_defines': [
     172          'ENABLE_ACCELERATED_OVERFLOW_SCROLLING=0',
    172173          'ENABLE_CALENDAR_PICKER=1',
    173174          'ENABLE_DATALIST_ELEMENT=1',
     
    181182          'ENABLE_NOTIFICATIONS=1',
    182183          'ENABLE_ORIENTATION_EVENTS=0',
    183           'ENABLE_OVERFLOW_SCROLLING=0',
    184184          'ENABLE_PAGE_POPUP=1',
    185185          'ENABLE_PRINTING=1',
  • trunk/Source/cmakeconfig.h.cmake

    r128065 r128347  
    44#cmakedefine01 ENABLE_3D_RENDERING
    55#cmakedefine01 ENABLE_ACCELERATED_2D_CANVAS
     6#cmakedefine01 ENABLE_ACCELERATED_OVERFLOW_SCROLLING
    67#cmakedefine01 ENABLE_ANIMATION_API
    78#cmakedefine01 ENABLE_API_TESTS
     
    8081#cmakedefine01 ENABLE_NOTIFICATIONS
    8182#cmakedefine01 ENABLE_ORIENTATION_EVENTS
    82 #cmakedefine01 ENABLE_OVERFLOW_SCROLLING
    8383#cmakedefine01 ENABLE_PAGE_POPUP
    8484#cmakedefine01 ENABLE_PAGE_VISIBILITY_API
Note: See TracChangeset for help on using the changeset viewer.