Changeset 128451 in webkit
- Timestamp:
- Sep 13, 2012 6:22:40 AM (12 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 23 edited
- 2 copied
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/CMakeLists.txt
r128261 r128451 1769 1769 platform/PlatformEvent.cpp 1770 1770 platform/PlatformInstrumentation.cpp 1771 platform/PlatformMemoryInstrumentation.cpp 1771 1772 platform/RunLoop.cpp 1772 1773 platform/RuntimeApplicationChecks.cpp -
trunk/Source/WebCore/ChangeLog
r128448 r128451 1 2012-09-13 Ilya Tikhonovsky <loislo@chromium.org> 2 3 Web Inspector: NMI: remove the dependency of platform sources from WebCore header introduced by NMI instrumentation. 4 https://bugs.webkit.org/show_bug.cgi?id=96367 5 6 Reviewed by Yury Semikhatsky. 7 8 the target is to move 'platform' specific instrumentation code 9 from WebCoreMemoryInstrumentation into the new PlatformMemoryInstrumentation. 10 11 Drive by fix: New type DOM.Image was introduced. 12 13 * CMakeLists.txt: 14 * GNUmakefile.list.am: 15 * Target.pri: 16 * WebCore.gypi: 17 * WebCore.vcproj/WebCore.vcproj: 18 * WebCore.xcodeproj/project.pbxproj: 19 * dom/WebCoreMemoryInstrumentation.cpp: 20 (WebCore): 21 * dom/WebCoreMemoryInstrumentation.h: 22 (WebCoreMemoryTypes): 23 * inspector/InspectorMemoryAgent.cpp: 24 (WebCore): 25 * platform/KURL.cpp: 26 * platform/KURLGoogle.cpp: 27 * platform/PlatformMemoryInstrumentation.cpp: Copied from Source/WebCore/platform/graphics/GeneratedImage.cpp. 28 (WebCore): 29 * platform/PlatformMemoryInstrumentation.h: Copied from Source/WebCore/platform/graphics/GeneratedImage.cpp. 30 (WebCore): 31 (PlatformMemoryTypes): 32 * platform/SharedBuffer.cpp: 33 * platform/TreeShared.h: 34 (WebCore::TreeShared::reportMemoryUsage): 35 * platform/graphics/BitmapImage.cpp: 36 (WebCore::BitmapImage::reportMemoryUsage): 37 * platform/graphics/CrossfadeGeneratedImage.cpp: 38 (WebCore::CrossfadeGeneratedImage::reportMemoryUsage): 39 * platform/graphics/GeneratedImage.cpp: 40 (WebCore::GeneratedImage::reportMemoryUsage): 41 * platform/graphics/GeneratorGeneratedImage.cpp: 42 (WebCore::GeneratorGeneratedImage::reportMemoryUsage): 43 * platform/graphics/GeneratorGeneratedImage.h: 44 * platform/graphics/Image.cpp: 45 (WebCore::Image::reportMemoryUsage): 46 * platform/network/FormData.cpp: 47 (WebCore::FormData::reportMemoryUsage): 48 * platform/network/ResourceRequestBase.cpp: 49 (WebCore::ResourceRequestBase::reportMemoryUsage): 50 * platform/network/ResourceResponseBase.cpp: 51 (WebCore::ResourceResponseBase::reportMemoryUsage): 52 1 53 2012-09-13 Ilya Tikhonovsky <loislo@chromium.org> 2 54 -
trunk/Source/WebCore/GNUmakefile.list.am
r128394 r128451 4690 4690 Source/WebCore/platform/PlatformGestureEvent.h \ 4691 4691 Source/WebCore/platform/PlatformKeyboardEvent.h \ 4692 Source/WebCore/platform/PlatformMemoryInstrumentation.cpp \ 4693 Source/WebCore/platform/PlatformMemoryInstrumentation.h \ 4692 4694 Source/WebCore/platform/PlatformMenuDescription.h \ 4693 4695 Source/WebCore/platform/PlatformMouseEvent.h \ -
trunk/Source/WebCore/Target.pri
r128394 r128451 1047 1047 platform/PlatformEvent.cpp \ 1048 1048 platform/PlatformInstrumentation.cpp \ 1049 platform/PlatformMemoryInstrumentation.cpp \ 1049 1050 platform/RuntimeApplicationChecks.cpp \ 1050 1051 platform/RunLoop.cpp \ … … 2217 2218 platform/network/qt/NetworkStateNotifierPrivate.h \ 2218 2219 platform/PlatformExportMacros.h \ 2220 platform/PlatformMemoryInstrumentation.h \ 2219 2221 platform/PlatformTouchEvent.h \ 2220 2222 platform/PlatformTouchPoint.h \ -
trunk/Source/WebCore/WebCore.gypi
r128394 r128451 4495 4495 'platform/Pasteboard.h', 4496 4496 'platform/PlatformGestureCurve.h', 4497 'platform/PlatformMemoryInstrumentation.cpp', 4498 'platform/PlatformMemoryInstrumentation.h', 4497 4499 'platform/PlatformStrategies.cpp', 4498 4500 'platform/PlatformTouchEvent.h', -
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
r128249 r128451 28612 28612 </File> 28613 28613 <File 28614 RelativePath="..\platform\PlatformMemoryInstrumentation.cpp" 28615 > 28616 </File> 28617 <File 28618 RelativePath="..\platform\PlatformMemoryInstrumentation.h" 28619 > 28620 </File> 28621 <File 28614 28622 RelativePath="..\platform\PlatformMenuDescription.h" 28615 28623 > -
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
r128394 r128451 1452 1452 4F1534DE11B532EC0021FD86 /* EditingBehavior.h in Headers */ = {isa = PBXBuildFile; fileRef = 4F1534DD11B532EC0021FD86 /* EditingBehavior.h */; settings = {ATTRIBUTES = (Private, ); }; }; 1453 1453 4F1534E011B533020021FD86 /* EditingBehaviorTypes.h in Headers */ = {isa = PBXBuildFile; fileRef = 4F1534DF11B533020021FD86 /* EditingBehaviorTypes.h */; settings = {ATTRIBUTES = (Private, ); }; }; 1454 4F1D11BF15FF37200026E908 /* PlatformMemoryInstrumentation.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4F1D118915FF361B0026E908 /* PlatformMemoryInstrumentation.cpp */; }; 1454 1455 4F2D205412EAE7B3005C2874 /* InspectorAgent.h in Headers */ = {isa = PBXBuildFile; fileRef = 4F2D205212EAE7B3005C2874 /* InspectorAgent.h */; settings = {ATTRIBUTES = (Private, ); }; }; 1455 1456 4F2D205512EAE7B3005C2874 /* InspectorAgent.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4F2D205312EAE7B3005C2874 /* InspectorAgent.cpp */; }; … … 1462 1463 4F707A9911EF679400ACDA69 /* InspectorBackendDispatcher.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4F707A9711EF679400ACDA69 /* InspectorBackendDispatcher.cpp */; }; 1463 1464 4F707A9A11EF679400ACDA69 /* InspectorBackendDispatcher.h in Headers */ = {isa = PBXBuildFile; fileRef = 4F707A9811EF679400ACDA69 /* InspectorBackendDispatcher.h */; settings = {ATTRIBUTES = (Private, ); }; }; 1465 4F7B4A6615FF6D6A006B5F22 /* PlatformMemoryInstrumentation.h in Headers */ = {isa = PBXBuildFile; fileRef = 4F1D118A15FF361B0026E908 /* PlatformMemoryInstrumentation.h */; settings = {ATTRIBUTES = (Private, ); }; }; 1464 1466 4F8565E91530356E00FAE776 /* MemoryInstrumentationImpl.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4F8565E71530356E00FAE776 /* MemoryInstrumentationImpl.cpp */; }; 1465 1467 4F8565EA1530356E00FAE776 /* MemoryInstrumentationImpl.h in Headers */ = {isa = PBXBuildFile; fileRef = 4F8565E81530356E00FAE776 /* MemoryInstrumentationImpl.h */; }; … … 8623 8625 4F1534DD11B532EC0021FD86 /* EditingBehavior.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = EditingBehavior.h; sourceTree = "<group>"; }; 8624 8626 4F1534DF11B533020021FD86 /* EditingBehaviorTypes.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = EditingBehaviorTypes.h; sourceTree = "<group>"; }; 8627 4F1D118915FF361B0026E908 /* PlatformMemoryInstrumentation.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = PlatformMemoryInstrumentation.cpp; sourceTree = "<group>"; }; 8628 4F1D118A15FF361B0026E908 /* PlatformMemoryInstrumentation.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PlatformMemoryInstrumentation.h; sourceTree = "<group>"; }; 8625 8629 4F2D205212EAE7B3005C2874 /* InspectorAgent.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = InspectorAgent.h; sourceTree = "<group>"; }; 8626 8630 4F2D205312EAE7B3005C2874 /* InspectorAgent.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = InspectorAgent.cpp; sourceTree = "<group>"; }; … … 20839 20843 49182B5115DCE6F000548418 /* PlatformInstrumentation.h */, 20840 20844 935C476609AC4D4300A6AAB4 /* PlatformKeyboardEvent.h */, 20845 4F1D118915FF361B0026E908 /* PlatformMemoryInstrumentation.cpp */, 20846 4F1D118A15FF361B0026E908 /* PlatformMemoryInstrumentation.h */, 20841 20847 932871BF0B20DEB70049035A /* PlatformMenuDescription.h */, 20842 20848 935C476709AC4D4300A6AAB4 /* PlatformMouseEvent.h */, … … 25555 25561 977E2E0F12F0FC9C00C13379 /* XSSAuditor.h in Headers */, 25556 25562 FD537353137B651800008DCE /* ZeroPole.h in Headers */, 25563 4F7B4A6615FF6D6A006B5F22 /* PlatformMemoryInstrumentation.h in Headers */, 25557 25564 ); 25558 25565 runOnlyForDeploymentPostprocessing = 0; … … 28652 28659 977E2E0E12F0FC9C00C13379 /* XSSAuditor.cpp in Sources */, 28653 28660 FD537352137B651800008DCE /* ZeroPole.cpp in Sources */, 28661 4F1D11BF15FF37200026E908 /* PlatformMemoryInstrumentation.cpp in Sources */, 28654 28662 ); 28655 28663 runOnlyForDeploymentPostprocessing = 0; -
trunk/Source/WebCore/dom/WebCoreMemoryInstrumentation.cpp
r128448 r128451 38 38 MemoryObjectType WebCoreMemoryTypes::CSS = "Page.CSS"; 39 39 MemoryObjectType WebCoreMemoryTypes::Binding = "Page.Binding"; 40 MemoryObjectType WebCoreMemoryTypes::Loader = "Page.Loader";41 40 42 41 MemoryObjectType WebCoreMemoryTypes::MemoryCache = "MemoryCache"; -
trunk/Source/WebCore/dom/WebCoreMemoryInstrumentation.h
r128448 r128451 32 32 #define WebCoreMemoryInstrumentation_h 33 33 34 #include <wtf/MemoryInstrumentation.h>34 #include "PlatformMemoryInstrumentation.h" 35 35 36 36 namespace WebCore { … … 39 39 using WTF::MemoryObjectType; 40 40 41 class WebCoreMemoryTypes {41 class WebCoreMemoryTypes : public PlatformMemoryTypes { 42 42 public: 43 43 static MemoryObjectType Page; … … 45 45 static MemoryObjectType CSS; 46 46 static MemoryObjectType Binding; 47 static MemoryObjectType Loader;48 47 49 48 static MemoryObjectType MemoryCache; -
trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp
r127738 r128451 482 482 RefPtr<TypeBuilder::Array<InspectorMemoryBlock> > domChildren = TypeBuilder::Array<InspectorMemoryBlock>::create(); 483 483 totalSize += addMemoryBlockFor(domChildren.get(), WebCoreMemoryTypes::DOM); 484 totalSize += addMemoryBlockFor(domChildren.get(), WebCoreMemoryTypes::Image); 484 485 totalSize += addMemoryBlockFor(domChildren.get(), WebCoreMemoryTypes::CSS); 485 486 totalSize += addMemoryBlockFor(domChildren.get(), WebCoreMemoryTypes::Binding); -
trunk/Source/WebCore/platform/KURL.cpp
r128448 r128451 29 29 30 30 #include "DecodeEscapeSequences.h" 31 #include "PlatformMemoryInstrumentation.h" 31 32 #include "TextEncoding.h" 32 #include "WebCoreMemoryInstrumentation.h"33 33 #include <stdio.h> 34 34 #include <wtf/HashMap.h> -
trunk/Source/WebCore/platform/KURLGoogle.cpp
r128448 r128451 42 42 43 43 #include "NotImplemented.h" 44 #include "PlatformMemoryInstrumentation.h" 44 45 #include "TextEncoding.h" 45 #include "WebCoreMemoryInstrumentation.h"46 46 #include <wtf/HashMap.h> 47 47 #include <wtf/Vector.h> -
trunk/Source/WebCore/platform/PlatformMemoryInstrumentation.cpp
r128450 r128451 30 30 31 31 #include "config.h" 32 #include "GeneratedImage.h" 33 34 #include "FloatSize.h" 35 #include "WebCoreMemoryInstrumentation.h" 36 32 #include "PlatformMemoryInstrumentation.h" 37 33 38 34 namespace WebCore { 39 35 40 void GeneratedImage::computeIntrinsicDimensions(Length& intrinsicWidth, Length& intrinsicHeight, FloatSize& intrinsicRatio) 41 { 42 Image::computeIntrinsicDimensions(intrinsicWidth, intrinsicHeight, intrinsicRatio); 43 intrinsicRatio = FloatSize(); 44 } 36 MemoryObjectType PlatformMemoryTypes::Image = "Page.Image"; 37 MemoryObjectType PlatformMemoryTypes::Loader = "Page.Loader"; 45 38 46 void GeneratedImage::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const 47 { 48 MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::CachedResourceImage); 49 Image::reportMemoryUsage(memoryObjectInfo); 50 } 51 52 } 39 } // namespace WebCore -
trunk/Source/WebCore/platform/PlatformMemoryInstrumentation.h
r128450 r128451 29 29 */ 30 30 31 #i nclude "config.h"32 # include "GeneratedImage.h"31 #ifndef PlatformMemoryInstrumentation_h 32 #define PlatformMemoryInstrumentation_h 33 33 34 #include "FloatSize.h" 35 #include "WebCoreMemoryInstrumentation.h" 36 34 #include <wtf/MemoryInstrumentation.h> 37 35 38 36 namespace WebCore { 39 37 40 void GeneratedImage::computeIntrinsicDimensions(Length& intrinsicWidth, Length& intrinsicHeight, FloatSize& intrinsicRatio) 41 { 42 Image::computeIntrinsicDimensions(intrinsicWidth, intrinsicHeight, intrinsicRatio); 43 intrinsicRatio = FloatSize(); 44 } 38 using WTF::MemoryClassInfo; 39 using WTF::MemoryObjectType; 45 40 46 void GeneratedImage::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const 47 { 48 MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::CachedResourceImage);49 Image::reportMemoryUsage(memoryObjectInfo);50 } 41 class PlatformMemoryTypes { 42 public: 43 static MemoryObjectType Image; 44 static MemoryObjectType Loader; 45 }; 51 46 52 } 47 } // namespace WebCore 48 49 #endif // !defined(PlatformMemoryInstrumentation_h) -
trunk/Source/WebCore/platform/SharedBuffer.cpp
r128300 r128451 28 28 #include "SharedBuffer.h" 29 29 30 #include "PlatformMemoryInstrumentation.h" 30 31 #include "PurgeableBuffer.h" 31 #include "WebCoreMemoryInstrumentation.h"32 32 #include <wtf/PassOwnPtr.h> 33 33 #include <wtf/unicode/UTF8.h> -
trunk/Source/WebCore/platform/TreeShared.h
r127593 r128451 114 114 void reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const 115 115 { 116 MemoryClassInfo info(memoryObjectInfo, this , WebCoreMemoryTypes::DOM);116 MemoryClassInfo info(memoryObjectInfo, this); 117 117 info.addInstrumentedMember(m_parent); 118 118 } -
trunk/Source/WebCore/platform/graphics/BitmapImage.cpp
r127869 r128451 32 32 #include "IntRect.h" 33 33 #include "MIMETypeRegistry.h" 34 #include "PlatformMemoryInstrumentation.h" 34 35 #include "Timer.h" 35 #include "WebCoreMemoryInstrumentation.h"36 36 #include <wtf/CurrentTime.h> 37 37 #include <wtf/Vector.h> … … 575 575 void BitmapImage::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const 576 576 { 577 MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::CachedResourceImage);577 MemoryClassInfo info(memoryObjectInfo, this, PlatformMemoryTypes::Image); 578 578 Image::reportMemoryUsage(memoryObjectInfo); 579 579 info.addMember(m_source); -
trunk/Source/WebCore/platform/graphics/CrossfadeGeneratedImage.cpp
r127869 r128451 30 30 #include "GraphicsContext.h" 31 31 #include "ImageBuffer.h" 32 #include " WebCoreMemoryInstrumentation.h"32 #include "PlatformMemoryInstrumentation.h" 33 33 34 34 using namespace std; … … 111 111 void CrossfadeGeneratedImage::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const 112 112 { 113 MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::DOM);113 MemoryClassInfo info(memoryObjectInfo, this, PlatformMemoryTypes::Image); 114 114 GeneratedImage::reportMemoryUsage(memoryObjectInfo); 115 115 info.addInstrumentedMember(m_fromImage); -
trunk/Source/WebCore/platform/graphics/GeneratedImage.cpp
r127869 r128451 33 33 34 34 #include "FloatSize.h" 35 #include " WebCoreMemoryInstrumentation.h"35 #include "PlatformMemoryInstrumentation.h" 36 36 37 37 … … 46 46 void GeneratedImage::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const 47 47 { 48 MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::CachedResourceImage);48 MemoryClassInfo info(memoryObjectInfo, this, PlatformMemoryTypes::Image); 49 49 Image::reportMemoryUsage(memoryObjectInfo); 50 50 } -
trunk/Source/WebCore/platform/graphics/GeneratorGeneratedImage.cpp
r127593 r128451 30 30 #include "GraphicsContext.h" 31 31 #include "Length.h" 32 #include "PlatformMemoryInstrumentation.h" 32 33 33 34 namespace WebCore { … … 88 89 void GeneratorGeneratedImage::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const 89 90 { 90 MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::DOM);91 MemoryClassInfo info(memoryObjectInfo, this, PlatformMemoryTypes::Image); 91 92 GeneratedImage::reportMemoryUsage(memoryObjectInfo); 92 93 info.addMember(m_generator); -
trunk/Source/WebCore/platform/graphics/GeneratorGeneratedImage.h
r127869 r128451 33 33 #include "IntSize.h" 34 34 #include "Timer.h" 35 #include "WebCoreMemoryInstrumentation.h"36 35 #include <wtf/RefPtr.h> 37 36 -
trunk/Source/WebCore/platform/graphics/Image.cpp
r127869 r128451 35 35 #include "Length.h" 36 36 #include "MIMETypeRegistry.h" 37 #include "PlatformMemoryInstrumentation.h" 37 38 #include "SharedBuffer.h" 38 #include "WebCoreMemoryInstrumentation.h"39 39 #include <math.h> 40 40 #include <wtf/MainThread.h> … … 201 201 void Image::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const 202 202 { 203 MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::CachedResourceImage);203 MemoryClassInfo info(memoryObjectInfo, this, PlatformMemoryTypes::Image); 204 204 info.addInstrumentedMember(m_data); 205 205 info.addMember(m_imageObserver); -
trunk/Source/WebCore/platform/network/FormData.cpp
r127869 r128451 34 34 #include "MIMETypeRegistry.h" 35 35 #include "Page.h" 36 #include "PlatformMemoryInstrumentation.h" 36 37 #include "TextEncoding.h" 37 #include "WebCoreMemoryInstrumentation.h"38 38 #include <wtf/Decoder.h> 39 39 #include <wtf/Encoder.h> … … 360 360 void FormData::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const 361 361 { 362 MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::Loader);362 MemoryClassInfo info(memoryObjectInfo, this, PlatformMemoryTypes::Loader); 363 363 info.addVector(m_boundary); 364 364 } -
trunk/Source/WebCore/platform/network/ResourceRequestBase.cpp
r127869 r128451 27 27 #include "ResourceRequestBase.h" 28 28 29 #include "PlatformMemoryInstrumentation.h" 29 30 #include "ResourceRequest.h" 30 #include "WebCoreMemoryInstrumentation.h"31 31 32 32 using namespace std; … … 447 447 void ResourceRequestBase::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const 448 448 { 449 MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::Loader);449 MemoryClassInfo info(memoryObjectInfo, this, PlatformMemoryTypes::Loader); 450 450 info.addInstrumentedMember(m_url); 451 451 info.addInstrumentedMember(m_firstPartyForCookies); -
trunk/Source/WebCore/platform/network/ResourceResponseBase.cpp
r127869 r128451 29 29 30 30 #include "HTTPParsers.h" 31 #include "PlatformMemoryInstrumentation.h" 31 32 #include "ResourceResponse.h" 32 #include "WebCoreMemoryInstrumentation.h"33 33 #include <wtf/CurrentTime.h> 34 34 #include <wtf/MathExtras.h> … … 571 571 void ResourceResponseBase::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const 572 572 { 573 MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::Loader);573 MemoryClassInfo info(memoryObjectInfo, this, PlatformMemoryTypes::Loader); 574 574 info.addInstrumentedMember(m_url); 575 575 info.addInstrumentedMember(m_mimeType);
Note: See TracChangeset
for help on using the changeset viewer.